Skip to content
  • Eli Schwartz's avatar
    libmakepkg/integrity: fix regression that broke --install · 9c8d7a80
    Eli Schwartz authored and Allan McRae's avatar Allan McRae committed
    In commit c6b04c04
    
     package signing was
    moved out of fakeroot, and as part of this process, the global pkgname
    variable was modified in order to extract the built package names.
    
    However, if a debug package was not available and added to the list of
    packages, the function was aborted early, before the pkgname array was
    restored, thereby corrupting the later stages of makepkg and
    specifically the install_package function which needs to know which
    pkgnames to install.
    
    Fix this by inlining the debug package signing inside the `if` check,
    and as added security switch to using `for pkg in "${pkgname[@]}"` as is
    done in many other parts of makepkg, since package signing does not
    depend on the value of pkgname for anything.
    
    Additionally, since debug packages may not actually exist, check if the
    package file exists first.
    
    Signed-off-by: default avatarEli Schwartz <eschwartz@archlinux.org>
    Signed-off-by: default avatarAllan McRae <allan@archlinux.org>
    9c8d7a80