GitLab

Shellcheck v0.7.2[1] added more checks resulting in the following
complains in our case:
In build-host.sh line 12:
  readonly TMPDIR="$(mktemp --dry-run --directory --tmpdir="${PWD}/tmp")"
           ^----^ SC2155: Declare and assign separately to avoid masking return values.
In build-inside-vm.sh line 16:
  readonly TMPDIR="$(mktemp --dry-run --directory --tmpdir="${PWD}/tmp")"
           ^----^ SC2155: Declare and assign separately to avoid masking return values.
In build-inside-vm.sh line 19:
    chown "${SUDO_UID}:${SUDO_GID}" "${OUTPUT}" "${TMPDIR}"
                       ^---------^ SC2153: Possible misspelling: SUDO_GID may not be assigned, but SUDO_UID is.

[1] https://github.com/koalaman/shellcheck/blob/331e89be990547b6e21ad1b6e56065bcda1ba053/CHANGELOG.md#v072---2021-04-19

haveged was presumably added to increase entropy and prevent entropy
starvation.

A few things has changed since, most notable:
* the kernel actively tries to add entropy (jitter entropy)[1][2][3][4]
* /dev/random no longer blocks after CRNG initialization[5][6]

[1] https://github.com/torvalds/linux/commit/3f2dc2798b81531fd93a3b9b7c39da47ec689e55
[2] https://github.com/torvalds/linux/commit/50ee7529ec4500c88f8664560770a7a1b65db72b
[3] https://lore.kernel.org/lkml/alpine.DEB.2.21.1909290010500.2636@nanos.tec.linutronix.de/T/
[4] https://lwn.net/Articles/800509/
[5] https://github.com/torvalds/linux/commit/30c08efec8884fb106b8e57094baa51bb4c44e32
[6] https://lwn.net/Articles/808575/

cloud-init resizes the disk[1] so we don't need a "big disk" with a lot
of unused space + some cloud providers charges for the unused space +
some cloud providers offers VM with disk < 20GB.

[1] https://cloudinit.readthedocs.io/en/latest/topics/modules.html#growpart

Fix #127

It saves us ~20MB.

The mkinitcpio autodetect hook removes modules not needed by the
running system from the initramfs. This make the image non-bootable
on some systems as initramfs lacks the relevant kernel modules.
Ex: Some systems need the virtio-scsi kernel module and not the
"autodetected" virtio-blk kernel module for disk access.

So for the initial install we use the fallback initramfs, and
"autodetect" should add the relevant modules to the initramfs when
the user updates the kernel.

It improves readability according to some..

build-inside-vm.sh:
Change the source of `/etc/resolv.conf` to point to
`/run/systemd/resolve/stub-resolv.conf`, as it provides support for
per-interface resolving [1].

Fixes #123

[1] https://www.freedesktop.org/software/systemd/man/systemd-resolved.service.html#/etc/resolv.conf

I'm not sure polkit is needed in the vagrant images, but it is
definitely not needed in the cloud-image.

It has never be enabled, makes zero sense in a cloud-image and isn't
used by vagrant.

https://cloudinit.readthedocs.io/en/latest/topics/modules.html#growpart

Even though the system isn't booted, a machine-id is generated when
systemd is installed (by the .install script).

Fixes: 0b60f5a4 ("Remove "remove machine-id" logic")

Fix #117

In my tests this gains us about 10MB.

We still have the problem where the partition table or device appears too late.
Hopefully this fixes it.

Fix #114

Kristian Klausen authored Sep 26, 2020 and Sven-Hendrik Haase committed Sep 26, 2020

netctl is only required by vagrant < v2.2.10

Kristian Klausen authored Sep 26, 2020 and Sven-Hendrik Haase committed Sep 26, 2020

Python was added due to DevOps demands (Ansible).
linux-headers is not needed and I'm not sure why it was added.

Fix #111

... and use readonly, local and adding a few more comments.

A machine-id is never generated, as the system isn't booted.