• Eli Schwartz's avatar
    fix broken SQL query that always failed · d92dd69a
    Eli Schwartz authored and Lukas Fleischer's avatar Lukas Fleischer committed
    
    
    Due to missing whitespace at the end of strings during joining, we ended
    up with the query fragment
    
    "DelTS IS NULLAND NOT PinnedTS"
    
    which should be
    
    "DelTS IS NULL AND NOT PinnedTS"
    
    So the check for pinned comments > 5 likely always failed.
    
    In php 7, a completely broken query that raises exceptions in the
    database engine was silently ignored... in php 8, it raises
    
    Uncaught PDOException: SQLSTATE[HY000]: General error: 1 near "PinnedTS": syntax error in <file>
    
    and aborts the page building. End result: users with permission to pin
    comments cannot see any comments, or indeed page content below the first
    comment header
    Signed-off-by: Eli Schwartz's avatarEli Schwartz <eschwartz@archlinux.org>
    Signed-off-by: Lukas Fleischer's avatarLukas Fleischer <lfleischer@archlinux.org>
    d92dd69a
pkgbasefuncs.inc.php 34.3 KB