Commit 095986b4 authored by Marcel Korpel's avatar Marcel Korpel Committed by Lukas Fleischer
Browse files

Do not allow empty comments



Fixes FS#45870.

Signed-off-by: default avatarMarcel Korpel <marcel.korpel@gmail.com>
Signed-off-by: Lukas Fleischer's avatarLukas Fleischer <lfleischer@archlinux.org>
parent 60433a93
......@@ -107,8 +107,7 @@ if (check_token()) {
list($ret, $output) = pkgbase_set_comaintainers($base_id, explode("\n", $_POST['users']));
} elseif (current_action("do_AddComment")) {
$uid = uid_from_sid($_COOKIE["AURSID"]);
pkgbase_add_comment($base_id, $uid, $_REQUEST['comment']);
$ret = true;
list($ret, $output) = pkgbase_add_comment($base_id, $uid, $_REQUEST['comment']);
$fragment = '#news';
} elseif (current_action("do_EditComment")) {
list($ret, $output) = pkgbase_edit_comment($_REQUEST['comment']);
......
......@@ -81,6 +81,10 @@ function pkgbase_comments($base_id, $limit, $include_deleted) {
function pkgbase_add_comment($base_id, $uid, $comment) {
$dbh = DB::connect();
if (trim($comment) == '') {
return array(false, __('Comment cannot be empty.'));
}
$q = "INSERT INTO PackageComments ";
$q.= "(PackageBaseID, UsersID, Comments, CommentTS) VALUES (";
$q.= intval($base_id) . ", " . $uid . ", ";
......@@ -102,6 +106,8 @@ function pkgbase_add_comment($base_id, $uid, $comment) {
if ($result) {
notify(array('comment', $uid, $base_id), $comment);
}
return array(true, __('Comment has been added.'));
}
/**
......@@ -860,6 +866,10 @@ function pkgbase_edit_comment($comment) {
return array(false, __("Missing comment ID."));
}
if (trim($comment) == '') {
return array(false, __('Comment cannot be empty.'));
}
$dbh = DB::connect();
if (can_edit_comment($comment_id)) {
$q = "UPDATE PackageComments ";
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment