- 06 Apr, 2011 1 commit
-
-
Lukas Fleischer authored
Signed-off-by:Lukas Fleischer <archlinux@cryptocrack.de>
-
- 05 Apr, 2011 2 commits
-
-
Lukas Fleischer authored
Ensures "$name" is always initialized, even if the package doesn't exist. Fixes PHP warnings appearing when retrieving package details of a package with an invalid ID. Signed-off-by: -
Lukas Fleischer authored
We removed the code depending on this a long time ago - drop it and add some note to "UPGRADING". Signed-off-by:
-
- 04 Apr, 2011 1 commit
-
-
Lukas Fleischer authored
Signed-off-by:
-
- 03 Apr, 2011 5 commits
-
-
Dan McGee authored
Signed-off-by:
Dan McGee <dan@archlinux.org> Signed-off-by:
-
Dan McGee authored
Signed-off-by:
-
Dan McGee authored
Instead, we just store dependencies directly in the PackageDepends table. Since we don't use this info anywhere besides the package details page, there is little value in precalculating what is in the AUR vs. what is not. An upgrade path is provided via several SQL statements in the UPGRADING document. There should be no user-visible change from this, but the DB schema gets a bit more sane and we no longer have loads of junk packages in our tables that are never shown to the end user. This should also help the MySQL query planner in several cases as we no longer have to be careful to exclude dummy packages on every query. Signed-off-by:
-
Dan McGee authored
Set it equal to the SubmittedTS field, which will be our indication the package is new when we show the logo on the front page of the AUR. This results in the ability to remove the use of the unindexable GREATEST() function from the AUR code everywhere we had to use it before to handle the 0 timestamp case. Note that there is no race condition here in calling UNIX_TIMESTAMP() twice- it always returns the time at the beginning of statment execution: mysql> select unix_timestamp(), sleep(2), unix_timestamp(); +------------------+----------+------------------+ | unix_timestamp() | sleep(2) | unix_timestamp() | +------------------+----------+------------------+ | 1300851746 | 0 | 1300851746 | +------------------+----------+------------------+ 1 row in set (2.00 sec) Signed-off-by: -
Dan McGee authored
We had a ton of duplicate code shared between the insert and update cases. Do a refactor so we can pull this stuff out below the if/else block and only need it there once, saving some headaches. Signed-off-by:
-
- 30 Mar, 2011 9 commits
-
-
Lukas Fleischer authored
Reject tarballs containing more than one directory or files outside a directory. Signed-off-by: -
Lukas Fleischer authored
Signed-off-by: -
Lukas Fleischer authored
Signed-off-by: -
Lukas Fleischer authored
end() expects a reference but we pass a function return value here. Using list() is a bit hacky as well as it expects a 0-based array whereas unpack() returns a 1-based array - thus we use "list(, $foo)". Signed-off-by: -
Lukas Fleischer authored
This is quite hacky but this way we can ensure users get comprehensible error messages when trying to upload ".tar.xz" or ".tar.bz2" files. Signed-off-by: -
Lukas Fleischer authored
Signed-off-by: -
Lukas Fleischer authored
Signed-off-by: -
Lukas Fleischer authored
Signed-off-by: -
Lukas Fleischer authored
Ensures there's no leftover (empty) file if something during initialization fails. Signed-off-by:
-
- 24 Mar, 2011 1 commit
-
-
Dan McGee authored
25 is woefully small for the number of packages many searches can return, and with 28000+ packages in AUR, it makes sense to show a lot more per page by default. The new choices of (50, 100, 250) happen to match those from the main site. Signed-off-by:
-
- 15 Mar, 2011 1 commit
-
-
Dan McGee authored
I've been wanting to kill this one for a long time. Signed-off-by:
-
- 12 Mar, 2011 1 commit
-
-
Lukas Fleischer authored
Regression introduced in commit ef8fab0c . Removed the strict check again instead of wrapping it in __() to ensure search URLs are language independent. Signed-off-by:
-
- 11 Mar, 2011 2 commits
-
-
Lukas Fleischer authored
Signed-off-by: -
Lukas Fleischer authored
Fix a lot of invalid XHTML in the templates and actions. There might still be some legacy code left, but this should cover most of it. Signed-off-by:
-
- 10 Mar, 2011 3 commits
-
-
Dan McGee authored
This removes the need for SQL_CALC_FOUND_ROWS which can really slow down queries in a lot of cases. The COUNT(*) query we end up performing can reuse a lot of the original clauses from our primary query, but we can really slim it up by omitting some joins and the sorting/limiting clauses. Signed-off-by:
-
Dan McGee authored
No functional change here; we should be rebuilding the same query at the end of the process. Signed-off-by:
-
Dan McGee authored
Signed-off-by:
-
- 09 Mar, 2011 1 commit
-
-
Lukas Fleischer authored
Signed-off-by:
-
- 04 Mar, 2011 13 commits
-
-
Dan McGee authored
Regression introduced in commit c39183c3 . Signed-off-by:
-
Dan McGee authored
And use implode() instead of some looping/first time logic. Signed-off-by:
-
Dan McGee authored
With our use of strtotime() in stats.inc, we are "required" to do so or at least the emitted warning tells us it is a good idea. Signed-off-by:
-
Dan McGee authored
Signed-off-by:
-
Dan McGee authored
For some reason we were doing this song and dance "iterate all the known parameters" business. This is totally unnecessary, clutters the links, and was spewing errors all over the place, so kill it. Signed-off-by:
-
Dan McGee authored
Signed-off-by:
-
Dan McGee authored
If we were displaying this without coming from a previous query submit, notices were emitted all over the place. Fix them by adding an isset() first to each variable we try to access. Signed-off-by:
-
Dan McGee authored
Required by query does not have a dep condition element. Signed-off-by:
-
Dan McGee authored
Signed-off-by:
-
Dan McGee authored
Signed-off-by:
-
Dan McGee authored
We don't need mysql_real_escape_string(), we need valid integer conversions. Signed-off-by:
-
Dan McGee authored
Since only TUs/Devs can delete packages, we can remove almost all checks except the account type check. And now that our DB uses foreign keys, all of the other deletes happen implicitly when a package is deleted so we don't need to take care of it here. Signed-off-by:
-
Dan McGee authored
This change is necessary to prevent this: mysql> delete from Users where ID = 112; ERROR 1451 (23000): Cannot delete or update a parent row: a foreign key constraint fails (`aur`.`Packages`, CONSTRAINT `Packages_ibfk_2` FOREIGN KEY (`SubmitterUID`) REFERENCES `Users` (`ID`) ON DELETE NO ACTION) As a bonus, due to foreign keys, orphaning of packages will be automatic. Signed-off-by:
-
