Skip to content

[User Testing] Package Requests

About

  • Feature: Package Requests
  • Route: https://localhost:8444/requests

Checklist

  • This feature testing stage has been completed.

Description

The workflow of a Package Request has been reworked.

In /requests, the Accept link for package requests is now a link to the relevant action required to accept the request.

In addition, non-TUs are now able to view and optionally close requests they created.

Relevant Actions:

  • Deletion: /pkgbase/{name}/delete
  • Merge: /pkgbase/{name}/merge
  • Orphan: /pkgbase/{name}/orphan
  • All: /packages bulk disown, delete or merge

In a non-bulk action, TUs are given the opportunity to supply ClosureComments for the request in a new Comments field located in the modified action pages. If no comments are supplied, ClosureComments are autogenerated by aurweb.

More-so, actions taken are now always tracked via request creation. For a deletion or merge request, a request is created if none yet exist. For disowning a package, however, a preexisting orphan request is required.

Changes

Modifications (requests):

  • /requests/{id}/close no longer provides an Accepted selection. All manual request closures will cause a rejection.
  • Relevent pkgbase actions now trigger request closures: /pkgbase/{name}/delete (deletion), /pkgbase/{name}/merge (merge) and /pkgbase/{name}/disown (orphan).
  • Comment fields have been added to /pkgbase/{name}/{delete,merge,disown}, which is used to set the PackageRequest.ClosureComment on pending requests. If the comment field is left blank, a closure comment is autogenerated.
  • Autogenerated request notifications are only sent out once as a closure notification.
  • Some markup has been fixed.

Modifications (disown/orphan):

  • Orphan requests are now handled through the same path as deletion/merge.
  • We now check for due date when disowning as non-maintainer; previously, this was only done for display and not functionally. This check applies to Trusted Users' disowning of a package.

This style of notification flow does reduce our visibility, but accounting can still be done via the close request; it includes the action, pkgbase name and the user who accepted it.

Reporters

Following is a list of reporters who have contributed to helping test this feature which is updated as feedback is provided.

Name GitLab User
Amin Vakil @aminvakil
Kevin Morris @kevr
Edited by Kevin Morris
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information