bash cleanup: coding style

Jelle van der Waarequested to merge
eschwartz/bash-cleanup into master

Created by: eli-schwartz

Use modern bash where possible, streamline some control flow issues, and fix a small bug in check_repo_permission() while I'm at it.

Merge request reports