GitLab

Christoph Hoopmann authored Oct 17, 2018 and Jouke Witteveen committed Nov 15, 2018

Signed-off-by: Christoph Hoopmann <christophhoopmann@gmail.com>

Depend on the interface, not on the implementation.
Nevertheless, for netctl, openresolv is the preferred implementation.

Inside double quotes, backslash is an escape character. Hence, it is
cleaner to use single quotes where backslashes may occur. This includes
pattern strings for print, grep, and sed.

This also allows hooks to alter the profile to be loaded.

The .include directive in systemd unit files has effectively been
deprecated since systemd v210. Its functionality is subsumed by
drop-in directories.

Strictly speaking, we should check with the SSIDEncoding value sent out
by the station, as specified in the 2012 version of 802.11 (page 566),
but wpa_supplicant does not (yet) expose this information and stations
may not set the field to UTF-8 and still encode their SSID accordingly.

We therefore assume SSIDs to be UTF-8 encoded (the only real alternative
is treating SSIDs as raw byte string) in wifi-menu. Note that wifi-menu
is only provided as a convenience and many/most use cases involve
writing profile files manually.

When the current character map is not set to UTF-8, wifi-menu will only
use ASCII characters in its screen output.
This can be forced using for example `LC_CTYPE=C wifi-menu`.

Thanks to Declspeck <declspeck@declblog.com> for their activity on the
Flyspray task.

Hooks can now tell the command to be executed by looking at $Command.
The value will be "start", "stop", or "" (undefined), depending on the
reason a profile is being sourced.

On termination, pppd runs a script to restore resolve.conf to the state it was
in before pppd started. When we do not wait for the termination of pppd to
complete, systemd kills this script and resolve.conf is not restored.

Reported by KF <kecef@aol.com> in FS#53572

Not using `quote_readline` also makes bash completion usable without the
bash-completion suite.

This covers some corner cases where, for instance, IFS does not contain
whitespace characters.

Reported by Michaël Cadilhac <michael@cadilhac.name>

According to hostnamectl(1), network configuration should only influence the
transient hostname.

Observed and reported by Stefan (steinwanderer).

The sed alternative to the grep/substring combination would be

    sed -n 's/ssid=//p;T_;q0;:_;$q1'

which is as beautiful as it is unreadable.

The shorthand && or || sets the return value to 1 when they fail, which
can then become the return value of a function.

Observed and reported by David Dorfman.

Florian Pritz via arch-projects authored Mar 14, 2017 and Jouke Witteveen committed Mar 14, 2017

Signed-off-by: Florian Pritz <bluewind@xinu.at>

A generated config file could be left behind.
This occurs for instance when a removable interface is removed when used
or when an interface is blocked by rfkill, but netctl is not instructed
to utilize its rfkill routines.

Turn "-L" into a default value of DhcpcdOption=, making it possible to forego
the parameter by setting the variable to an empty string.

DhcpcdOptions= is currently not documented. The last documentation read:
"Do not use this unless you know what you are doing."
When using this variable, "-L" now has to be added if its functionality is
desired.