GitLab

The same functionality is provided by wpa_supplicant, so we do not need
an extra and Arch Linux specific dependency.

When accept_ra is set to 1, router advertisements are still ignored if
the interface is in forwarding mode. For such configurations, the
interface should have a static configuration and netctl already sets
accept_ra to 0. Setting it to 2 otherwise forces the kernel to accept
router advertisements regardless of the forwarding setting.

Eli Schwartz authored Jan 26, 2019 and Jouke Witteveen committed Feb 07, 2019

The Makefile commands in use include bash-specific features like brace
expansion, and thus cannot run under the default /bin/sh shell as that
may or may not be GNU bash (bash supports brace expansion even in posix
mode).

Consequently, the Makefile failed to execute correctly when the system
/bin/sh was a different sh implementation, such as dash or busybox ash.

Fix this by declaring the SHELL which will be used when running all
commands.

Christoph Hoopmann authored Oct 17, 2018 and Jouke Witteveen committed Nov 15, 2018

Signed-off-by: Christoph Hoopmann <christophhoopmann@gmail.com>

Depend on the interface, not on the implementation.
Nevertheless, for netctl, openresolv is the preferred implementation.

Inside double quotes, backslash is an escape character. Hence, it is
cleaner to use single quotes where backslashes may occur. This includes
pattern strings for print, grep, and sed.

This also allows hooks to alter the profile to be loaded.

The .include directive in systemd unit files has effectively been
deprecated since systemd v210. Its functionality is subsumed by
drop-in directories.

Strictly speaking, we should check with the SSIDEncoding value sent out
by the station, as specified in the 2012 version of 802.11 (page 566),
but wpa_supplicant does not (yet) expose this information and stations
may not set the field to UTF-8 and still encode their SSID accordingly.

We therefore assume SSIDs to be UTF-8 encoded (the only real alternative
is treating SSIDs as raw byte string) in wifi-menu. Note that wifi-menu
is only provided as a convenience and many/most use cases involve
writing profile files manually.

When the current character map is not set to UTF-8, wifi-menu will only
use ASCII characters in its screen output.
This can be forced using for example `LC_CTYPE=C wifi-menu`.

Thanks to Declspeck <declspeck@declblog.com> for their activity on the
Flyspray task.

Hooks can now tell the command to be executed by looking at $Command.
The value will be "start", "stop", or "" (undefined), depending on the
reason a profile is being sourced.

On termination, pppd runs a script to restore resolve.conf to the state it was
in before pppd started. When we do not wait for the termination of pppd to
complete, systemd kills this script and resolve.conf is not restored.

Reported by KF <kecef@aol.com> in FS#53572

Not using `quote_readline` also makes bash completion usable without the
bash-completion suite.

This covers some corner cases where, for instance, IFS does not contain
whitespace characters.

Reported by Michaël Cadilhac <michael@cadilhac.name>

According to hostnamectl(1), network configuration should only influence the
transient hostname.

Observed and reported by Stefan (steinwanderer).

The sed alternative to the grep/substring combination would be

    sed -n 's/ssid=//p;T_;q0;:_;$q1'

which is as beautiful as it is unreadable.

The shorthand && or || sets the return value to 1 when they fail, which
can then become the return value of a function.

Observed and reported by David Dorfman.

Florian Pritz via arch-projects authored Mar 14, 2017 and Jouke Witteveen committed Mar 14, 2017

Signed-off-by: Florian Pritz <bluewind@xinu.at>

A generated config file could be left behind.
This occurs for instance when a removable interface is removed when used
or when an interface is blocked by rfkill, but netctl is not instructed
to utilize its rfkill routines.