Hooks and interface scripts are now sourced more systematically.
Settings of wireless profiles that depend on hooks are now picked up
correctly by netctl-auto.

Suggested by: Vitor Sakaguti <vis@tutao.de>

The name of the subcommand mirrors the same subcommand of systemd-analyze.

Verification before restarting would be useful. However, verification
requires the profile file to be readable by the current user. The current
user may be a regular user with permission to control systemd, so
restarting does not require the profile file to be readable. Therefore, we
do not attempt verification before restarting.

Семён Марьясин authored May 31, 2020 and Jouke Witteveen committed Jun 26, 2020

When you call `netctl list`, it calls `systemctl status` for each of the
profiles. By default, `systemctl status` fetches the last log entries from the
journal, which is often a time-consuming operation. Additionally, the status
output is not meant for machine processing.

Inside double quotes, backslash is an escape character. Hence, it is
cleaner to use single quotes where backslashes may occur. This includes
pattern strings for print, grep, and sed.

This also allows hooks to alter the profile to be loaded.

Hooks can now tell the command to be executed by looking at $Command.
The value will be "start", "stop", or "" (undefined), depending on the
reason a profile is being sourced.

This covers some corner cases where, for instance, IFS does not contain
whitespace characters.

Reported by Michaël Cadilhac <michael@cadilhac.name>

The netctl@ service now yields before obtaining an IP address. This
prevents holding up network.target unnecessarily. Waiting for profiles
to obtain an IP address is possible through

1) The netctl-wait-online service
This service waits until all enabled profiles have obtained an address.
It is ordered before network-online.target so that this target is now
correctly implemented in netctl.

2) The wait-online <PROFILE> subcommand to netctl
This command waits for a started profile to obtain an address.

Some things should not be run with the restrictive umask.
This provides a means to do so: do_readable.

It is not of much use.

Also: tag error messages as systemd error messages when the messages are
not directed to the terminal.

Netctl files can potentially contain passwords or execute code as root.

The hooks (including any interface hook)  are loaded each time a wpa
event occurs. This means the auto.action script can be extended in the
hooks. For this purpose, several exported variables (mainly $ACTION)
can be checked for their value. The name of the active profile is not
exported, but still available (just as in ordinary netctl usage) through
the $Profile variable.

Profiles ending in .action are disallowed (reserved for possible future
use). Both ifplugd and wpa_actiond have a notion of 'action script'.

Profiles now have access to it.

Ivan Shapovalov authored May 17, 2013 and Jouke Witteveen committed May 17, 2013

Substituting "/dev/null/nonexistent" for an empty $Connection,
of course, does generally work, but is somewhat ugly (esp. in that
the string is appended to $CONN_DIR, so the resulting path may
theoretically exist).

Instead, substitute an empty string for the complete path if $Connection
is empty: an empty string can never be readable.
Signed-off-by: Ivan Shapovalov <intelfx100@gmail.com>

When interpreted as an array, the empty string represents a 1-element
array consisting of the empty string. This is actually very reasonable.

Reported by: Thomas Bächler <thomas@archlinux.org>

This allows connection scripts to provide defaults, among other things.

Old location: /etc/network.d
New location: /etc/netctl

This should ease migration from netcfg and is a better path anyway.

This settles a style for 'case' statements:
The label and closing colons are indented with two spaces,
The body is indented with two more, totalling four spaces.

This commit contains the refactoring and rewriting of code.

This commit contains the moving of files.

quirk() is not used anymore, inarray() doesn't belong in src/network.

This should fix FS#30361 along the way.

After this change, a profile started by a previous version of netcfg can potentially not be brought down anymore. This only concerns the updating process. Running `netcfg clean` should make everything OK again (potentially leaving your network down, but you can now bring up profiles again).

/etc/rc.d/functions is owned by initscripts on which netcfg does not explicitly depend.
The revised layout is inspired by systemd.

Add spaces where necessary.

It needs to be quoted when used as an argument. Putting the name in curly braces is unnecessary.

Bash completion does not deal properly with profile filenames that contain whitespace.
There are some minor tweaks in this commit as well, but those should be harmless.

Signed-off-by: Jim Pryor <profjim@jimpryor.net>

Signed-off-by: Jim Pryor <profjim@jimpryor.net>

* added various quotes
* made some vars local
* tweaked some [[ ]]s, including one broken one in netcfg-menu
* s/ra0/$INTERFACE/ in ethernet-iproute and wireless
Signed-off-by: Jim Pryor <profjim@jimpryor.net>

 Added some extra debug points
 Directed debug out to stderr, as debug messages were being used as
output from find_essid.