On termination, pppd runs a script to restore resolve.conf to the state it was
in before pppd started. When we do not wait for the termination of pppd to
complete, systemd kills this script and resolve.conf is not restored.

Reported by KF <kecef@aol.com> in FS#53572

Not using `quote_readline` also makes bash completion usable without the
bash-completion suite.

This covers some corner cases where, for instance, IFS does not contain
whitespace characters.

Reported by Michaël Cadilhac <michael@cadilhac.name>

According to hostnamectl(1), network configuration should only influence the
transient hostname.

Observed and reported by Stefan (steinwanderer).

The sed alternative to the grep/substring combination would be

    sed -n 's/ssid=//p;T_;q0;:_;$q1'

which is as beautiful as it is unreadable.

The shorthand && or || sets the return value to 1 when they fail, which
can then become the return value of a function.

Observed and reported by David Dorfman.

Florian Pritz via arch-projects authored Mar 14, 2017 and Jouke Witteveen committed Mar 14, 2017

Signed-off-by: Florian Pritz <bluewind@xinu.at>

A generated config file could be left behind.
This occurs for instance when a removable interface is removed when used
or when an interface is blocked by rfkill, but netctl is not instructed
to utilize its rfkill routines.

Turn "-L" into a default value of DhcpcdOption=, making it possible to forego
the parameter by setting the variable to an empty string.

DhcpcdOptions= is currently not documented. The last documentation read:
"Do not use this unless you know what you are doing."
When using this variable, "-L" now has to be added if its functionality is
desired.

Distinguish between started profiles and online profiles in the output
of the list subcommand of netctl.
To be consistent in symbol usage, the wifi-menu flags have changed too.

The netctl@ service now yields before obtaining an IP address. This
prevents holding up network.target unnecessarily. Waiting for profiles
to obtain an IP address is possible through

1) The netctl-wait-online service
This service waits until all enabled profiles have obtained an address.
It is ordered before network-online.target so that this target is now
correctly implemented in netctl.

2) The wait-online <PROFILE> subcommand to netctl
This command waits for a started profile to obtain an address.

Romain Aigron authored Oct 28, 2016 and Jouke Witteveen committed Nov 23, 2016

This patch fixes completion for the netctl and netctl_auto
commands for profiles names, treating them as filenames.
This allow proper completion for profiles with spaces or quotes in their
name (as it happends for instance with wifi-menu's autogenerated profile
names)

Signed-off-by: Romain Aigron <aigron.romain@wanadoo.fr>

Bring the exclusion pattern up to date with the currently used pattern.

This adds the LinkOptions= variable for use with connection types that
add interfaces (bond, bridge, dummy, macvlan, vlan). This variable is
not portable in the event of moving away from iproute2, so common
options should still get their own variables.

Bring the $Interface for pppoe connections ($BindsToInterfaces for ppp
connections) back down when pppd fails so that restarting pppoe
connections is possible.

Status getting commands are now uniform between netctl and netctl-auto.
Both support 'is-active' and 'is-enabled'. The 'current' command is
dropped from netctl-auto. Its use case is covered by the 'list' command.

Suggested by Evgeniy Alekseev <i@arcanis.me>

Robert Fenk authored Dec 16, 2015 and Jouke Witteveen committed Jun 10, 2016

netctl-auto/wpa_actiond will hang on startup, if wpa_supplicant creates
an additional control interface and with the -W switch waits for a
connection on all control interfaces on startup.

There was a typo in the code that checked whether wpa_supplicant was
already terminated that made us try to kill a non-existing instance of
wpa_supplicant.