segfault in x265Encoder::encode

Description:

Attempting to concatenate 2 videos with the x265 encoder triggers a segfault.

Additional info:

Our patch seems to be the cause of this :

208           x265_picture      *pic_out;
209           api->picture_init(&param,pic_out);

Ok, pic_out is an uninitialized pointer;

989     void x265_picture_init(x265_param *param, x265_picture *pic)
990     {
991         memset(pic, 0, sizeof(x265_picture));

Are we not memsetting to a random location here ?

  • package version(s): avidemux-qt 2.8.1 , x265 4.0

Steps to reproduce:

  1. drag-drop a video to the GUI, twice (this appends the second one)
  2. set encoder to x265
  3. export