Skip to content

Incorrect reported version, 'dev' instead of 'v11.1.2'

Description:

The forgejo-runner describes its version simply as 'dev', instead of the correct version.

Additional info:

  • package version(s): 11.1.2

Steps to reproduce:

$ forgejo-runner -v
forgejo-runner version dev

This is probably not the fully correct way, but when looking at the Makefile, it seems to set -X "code.forgejo.org/forgejo/runner/v11/internal/pkg/ver.version=$VERSION instead of -X main.version=$VERSION.

With this patch, the current version builds correclty:

diff --git a/PKGBUILD b/PKGBUILD
index be5eb31..569ae43 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -54,7 +54,7 @@ build() {
     -ldflags "-compressdwarf=false \
     -linkmode external \
     -extldflags '${LDFLAGS}' \
-    -X main.version=$pkgver'" \
+    -X "code.forgejo.org/forgejo/runner/v11/internal/pkg/ver.version=v${pkgver} \
     -o build/forgejo-runner \
     .

but that contains v11 in the path, that's why I don't think that that is the full solution.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information