Tests don't work for 2.4.1
When trying to build 2.4.1 (after removing the now unneeded patch and the simplecov cleanup code) I get this:
A new release of RubyGems is available: 3.6.7 → 3.6.8!
Run `gem update --system 3.6.8` to update your installation.
removed 'tmp_install/usr/lib/ruby/gems/3.4.0/cache/rubyzip-2.4.1.gem'
removed directory 'tmp_install/usr/lib/ruby/gems/3.4.0/cache/'
==> Starting check()...
/usr/bin/ruby -w -I"lib:lib:test" /usr/lib/ruby/gems/3.4.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb "test/basic_zip_file "test/filesystem/dir_iterator_test.rb" "test/filesystem/directory_test.rb" "test/filesystem/file_mutating_test.rb" "test/filesystem/file_nonmutating_test.rb" "test/filesystem/file_stat_test.rb" "test/inflater_test.rb" "test/input_stream_test.rb" "test/ioextras/abstract_input_stream_test.rb" "test/ioextras/abstract_output_stream_test.rb" "test/ioextras/fake_io_test.rb" "test/local_entry_test.rb" "test/output_stream_test.rb" "test/pass_thru_compressor_test.rb" "test/pass_thru_decompressor_test.rb" "test/path_traversal_test.rb" "test/samples/example_recursive_test.rb" "test/settings_test.rb" "test/stored_support_test.rb" "test/unicode_file_names_and_comments_test.rb" "test/version_3_api_test.rb" "test/zip64_full_test.rb" "test/zip64_support_test.rb"
Run options: --seed 35747
# Running:
..................................................................................................................E............................................................................/build/ruby-rubyzip/src/rubyzip-2.4.1/test/ioextras/abstract_output_stream_test.rb:53: warning: '$\' is deprecated
/build/ruby-rubyzip/src/rubyzip-2.4.1/test/ioextras/abstract_output_stream_test.rb:60: warning: '$,' is deprecated
......................................................................................................................................
Finished in 0.263560s, 1233.1170 runs/s, 11412.9723 assertions/s.
1) Error:
ConstantsTest#test_version_number_format:
NameError: uninitialized constant Zip::VERSION
test/constants_test.rb:7:in 'ConstantsTest#test_version_number_format'
325 runs, 3008 assertions, 0 failures, 1 errors, 0 skips
rake aborted!
Command failed with status (1): [ruby -w -I"lib:lib:test" /usr/lib/ruby/gems/3.4.0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb "test/basic_zip_file_test.rb" "test/bzip2_support_test.rb" "test/case_sensitivity_test.rb" "test/central_directory_entry_test.rb" "test/central_directory_test.rb" "test/constants_test.rb" "test/crypto/null_encryption_test.rb" "test/crypto/traditional_encryption_test.rb" "test/decompressor_test.rb" "test/deflater_test.rb" "test/encryption_test.rb" "test/entry_set_test.rb" "test/entry_test.rb" "test/errors_test.rb" "test/extra_field_test.rb" "test/extra_field_ut_test.rb" "test/file_extract_directory_test.rb" "test/file_extract_test.rb" "test/file_options_test.rb" "test/file_permissions_test.rb" "test/file_split_test.rb" "test/file_test.rb" "test/filesystem/dir_iterator_test.rb" "test/filesystem/directory_test.rb" "test/filesystem/file_mutating_test.rb" "test/filesystem/file_nonmutating_test.rb" "test/filesystem/file_stat_test.rb" "test/inflater_test.rb" "test/input_stream_test.rb" "test/ioextras/abstract_input_stream_test.rb" "test/ioextras/abstract_output_stream_test.rb" "test/ioextras/fake_io_test.rb" "test/local_entry_test.rb" "test/output_stream_test.rb" "test/pass_thru_compressor_test.rb" "test/pass_thru_decompressor_test.rb" "test/path_traversal_test.rb" "test/samples/example_recursive_test.rb" "test/settings_test.rb" "test/stored_support_test.rb" "test/unicode_file_names_and_comments_test.rb" "test/version_3_api_test.rb" "test/zip64_full_test.rb" "test/zip64_support_test.rb" ]
Tasks: TOP => test
(See full trace by running task with --trace)
==> ERROR: A failure occurred in check().
The tests seem, to work upstream: https://github.com/rubyzip/rubyzip/actions/runs/13236216949/job/36941531451
Edited by Andreas Schleifer