• Mikulas Patocka's avatar
    affs: fix remount failure when there are no options changed · 01d6e087
    Mikulas Patocka authored
    Commit c8f33d0b ("affs: kstrdup() memory handling") checks if the
    kstrdup function returns NULL due to out-of-memory condition.
    However, if we are remounting a filesystem with no change to
    filesystem-specific options, the parameter data is NULL.  In this case,
    kstrdup returns NULL (because it was passed NULL parameter), although no
    out of memory condition exists.  The mount syscall then fails with
    This patch fixes the bug.  We fail with ENOMEM only if data is non-NULL.
    The patch also changes the call to replace_mount_options - if we didn't
    pass any filesystem-specific options, we don't call
    replace_mount_options (thus we don't erase existing reported options).
    Fixes: c8f33d0b
     ("affs: kstrdup() memory handling")
    Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
    Cc: stable@vger.kernel.org	# v4.1+
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>