This project is mirrored from Pull mirroring updated .
  1. 19 Sep, 2012 2 commits
  2. 06 Sep, 2012 1 commit
    • Takashi Iwai's avatar
      ALSA: usb-audio: Fix bogus error messages for delay accounting · 1213a205
      Takashi Iwai authored
      The recent fix for the missing fine delayed time adjustment gives
      strange error messages at each start of the playback stream, such as
        delay: estimated 0, actual 352
        delay: estimated 353, actual 705
      These come from the sanity check in retire_playback_urb().  Before the
      stream is activated via start_endpoints(), a few silent packets have
      been already sent.  And at this point the delay account is still in
      the state as if the new packets are just queued, so the driver gets
      confused and spews the bogus error messages.
      For fixing the issue, we just need to check whether the received
      packet is valid, whether it's zero sized or not.
      Reported-by: default avatarMarkus Trippelsdorf <>
      Cc: <> [v3.5+]
      Signed-off-by: default avatarTakashi Iwai <>
  3. 31 Aug, 2012 3 commits
    • Daniel Mack's avatar
      ALSA: snd-usb: fix cross-interface streaming devices · 2e4a263c
      Daniel Mack authored
      Commit 68e67f40
       ("ALSA: snd-usb: move calls to usb_set_interface")
      saved us some unnecessary calls to snd_usb_set_interface() but ignored
      the fact that there is at least one device out there which operates on
      two endpoint in different interfaces simultaniously.
      Take care for this by catching the case where data and sync endpoints
      are located on different interfaces and calling snd_usb_set_interface()
      between the start of the two endpoints.
      Signed-off-by: default avatarDaniel Mack <>
      Reported-by: default avatarRobert M. Albrecht <>
      Cc: [v3.5+]
      Signed-off-by: default avatarTakashi Iwai <>
    • Daniel Mack's avatar
      ALSA: snd-usb: fix calls to next_packet_size · 245baf98
      Daniel Mack authored
      In order to support devices with implicit feedback streaming models,
      packet sizes are now stored with each individual urb, and the PCM
      handling code which fills the buffers purely relies on the size fields
      However, calling snd_usb_audio_next_packet_size() for all possible
      packets in an URB at once, prior to letting the PCM code do its job
      does in fact not lead to the same behaviour than what the old code did:
      The PCM code will break its loop once a period boundary is reached,
      consequently using up less packets that it really could.
      As snd_usb_audio_next_packet_size() implements a feedback mechanism to
      the endpoints phase accumulator, the number of calls to that function
      matters, and when called too often, the data rate runs out of bounds.
      Fix this by making the next_packet function public, and call it from the
      PCM code as before if the packet data sizes are not defined.
      Signed-off-by: default avatarDaniel Mack <>
      Cc: [v3.5+]
      Signed-off-by: default avatarTakashi Iwai <>
    • Daniel Mack's avatar
      ALSA: snd-usb: restore delay information · fbcfbf5f
      Daniel Mack authored
      Parts of commit 294c4fb8
       ("ALSA: usb: refine delay information with USB
      frame counter") were unfortunately lost during the refactoring of the
      snd-usb driver in 3.5.
      This patch adds them back, restoring the correct delay information
      Signed-off-by: default avatarDaniel Mack <>
      Cc: Pierre-Louis Bossart <>
      Cc: [3.5+]
      Signed-off-by: default avatarTakashi Iwai <>
  4. 30 Aug, 2012 1 commit
    • Daniel Mack's avatar
      ALSA: snd-usb: Fix URB cancellation at stream start · 015618b9
      Daniel Mack authored
      Commit e9ba389c
       ("ALSA: usb-audio: Fix scheduling-while-atomic bug in
      PCM capture stream") fixed a scheduling-while-atomic bug that happened
      when snd_usb_endpoint_start was called from the trigger callback, which
      is an atmic context. However, the patch breaks the idea of the endpoints
      reference counting, which is the reason why the driver has been
      refactored lately.
      Revert that commit and let snd_usb_endpoint_start() take care of the URB
      cancellation again. As this function is called from both atomic and
      non-atomic context, add a flag to denote whether the function may sleep.
      Signed-off-by: default avatarDaniel Mack <>
      Cc: [3.5+]
      Signed-off-by: default avatarTakashi Iwai <>
  5. 16 Aug, 2012 1 commit
  6. 13 Jul, 2012 1 commit
  7. 06 Jul, 2012 1 commit
    • Takashi Iwai's avatar
      ALSA: usb-audio: Fix the first PCM interface assignment · 9e9b5946
      Takashi Iwai authored
      In the new PCM streaming logic, the interface number is assigned to
      usb stream instance (subs->interface) after the format and rate setups
      are succeeded, but some codes are still passing subs->interface as the
      reference to helper functions.  This leads to initializing with an
      invalid iface number (-1).
      This patch replaces the wrong references with the ones from the target
      fmt correctly.
      Signed-off-by: default avatarTakashi Iwai <>
  8. 18 Jun, 2012 2 commits
  9. 31 May, 2012 1 commit
  10. 21 May, 2012 1 commit
  11. 13 Apr, 2012 2 commits
  12. 15 Mar, 2012 1 commit
  13. 27 Sep, 2011 1 commit
  14. 14 Sep, 2011 1 commit
  15. 12 Sep, 2011 1 commit
    • Pierre-Louis Bossart's avatar
      ALSA: usb: refine delay information with USB frame counter · 294c4fb8
      Pierre-Louis Bossart authored
      Existing code only updates the audio delay when URBs were
      submitted/retired. This can introduce an uncertainty of 8ms
      on the number of samples played out with the default settings,
      and a lot more when URBs convey more packets to reduce the
      interrupt rate and power consumption.
      This patch relies on the USB frame counter to reduce the
      uncertainty to less than 2ms worst-case. The delay information
      essentially becomes independent of the URB size and number of
      packets. This should help applications like PulseAudio which
      require accurate audio timing. Clemens Ladisch reported
      a decrease of mplayer's A-V difference from nrpacks down to at
      most 1ms.
      Thanks to Clemens for also pointing out that the implementation
      of frame counters varies between different HCDs. Only the
      8 lowest-bits are used to estimate the delay.
      Signed-off-by: default avatarPierre-Louis Bossart <>
      [clemens: changed debug code]
      Signed-off-by: default avatarClemens Ladisch <>
      Signed-off-by: default avatarTakashi Iwai <>
  16. 11 Mar, 2011 1 commit
  17. 23 Feb, 2011 1 commit
    • Takashi Iwai's avatar
      ALSA: usb-audio: fix oops due to cleanup race when disconnecting · 382225e6
      Takashi Iwai authored
      When a USB audio device is disconnected, snd_usb_audio_disconnect()
      kills all audio URBs.  At the same time, the application, after being
      notified of the disconnection, might close the device, in which case
      ALSA calls the .hw_free callback, which should free the URBs too.
      Commit de1b8b93
       "[ALSA] Fix hang-up at disconnection of usb-audio"
      prevented snd_usb_hw_free() from freeing the URBs to avoid a hang that
      resulted from this race, but this introduced another race because the
      URB callbacks could now be executed after snd_usb_hw_free() has
      returned, and try to access already freed data.
      Fix the first race by introducing a mutex to serialize the disconnect
      callback and all PCM callbacks that manage URBs (hw_free and hw_params).
      Reported-and-tested-by: default avatarPierre-Louis Bossart <>
      Cc: <>
      [CL: also serialize hw_params callback]
      Signed-off-by: default avatarClemens Ladisch <>
      Signed-off-by: default avatarTakashi Iwai <>
  18. 01 Nov, 2010 1 commit
  19. 27 Oct, 2010 1 commit
    • Clemens Ladisch's avatar
      ALSA: usb-audio: automatically detect feedback format · 89e1e66d
      Clemens Ladisch authored
      There are two USB Audio Class specifications (v1 and v2), but neither of
      them clearly defines the feedback format for high-speed UAC v1 devices.
      Add to this whatever the Creative and M-Audio firmware writers have been
      smoking, and it becomes impossible to predict the exact feedback format
      used by a particular device.
      Therefore, automatically detect the feedback format by looking at the
      magnitude of the first received feedback value.
      Also, this allows us to get rid of some special cases for E-Mu devices.
      Signed-off-by: default avatarClemens Ladisch <>
      Signed-off-by: default avatarTakashi Iwai <>
  20. 03 Sep, 2010 1 commit
    • Clemens Ladisch's avatar
      ALSA: usb-audio: fix detection of vendor-specific device protocol settings · a2acad82
      Clemens Ladisch authored
      The Audio Class v2 support code in 2.6.35 added checks for the
      bInterfaceProtocol field.  However, there are devices (usually those
      detected by vendor-specific quirks) that do not have one of the
      predefined values in this field, which made the driver reject them.
      To fix this regression, restore the old behaviour, i.e., assume that
      a device with an unknown bInterfaceProtocol field (other than
      UAC_VERSION_2) has more or less UAC-v1-compatible descriptors.
      [compile warning fixes by tiwai]
      Signed-off-by: default avatarClemens Ladisch <>
      Cc: Daniel Mack <>
      Cc: <>
      Signed-off-by: default avatarTakashi Iwai <>
  21. 14 Aug, 2010 1 commit
    • Paul Zimmerman's avatar
      ALSA: usb: USB3 SuperSpeed sound support · 4f4e8f69
      Paul Zimmerman authored
      This is V2 of the patch, after feedback from Clemens and Daniel.
      This patch adds SuperSpeed support to the USB drivers under sound/. It adds
      tests for USB_SPEED_SUPER to the appropriate places that check for the USB
      This patch has been tested with our SS USB3 device emulating a set of Yamaha
      speakers and a Logitech microphone, but with the descriptors modified to add
      USB3 support. It has also been tested with the real speakers and microphone,
      to make sure that USB2 devices still work.
      Signed-off-by: default avatarPaul Zimmerman <>
      Cc: Clemens Ladisch <>
      Cc: Daniel Mack <>
      Cc: Greg Kroah-Hartman <>
      Signed-off-by: default avatarTakashi Iwai <>
  22. 12 Jul, 2010 1 commit
  23. 31 May, 2010 1 commit
    • Daniel Mack's avatar
      ALSA: usb-audio: parse clock topology of UAC2 devices · 79f920fb
      Daniel Mack authored
      Audio devices which comply to the UAC2 standard can export complex clock
      topologies in its descriptors and set up links between them.
      The entities that are defined are
       - clock sources, which define the end-leafs.
       - clock selectors, which act as switch to select one out of many
         possible clocks sources.
       - clock multipliers, which have an input clock source, and act as clock
         source again. They can be used to derive one clock from another.
      All sample rate changes, clock validity queries and the like must go to
      clock source elements, while clock selectors and multipliers can be used
      as terminal clock source.
      The following patch adds a parser for these elements and functions to
      iterate over the tree and find the leaf nodes (clock sources).
      The samplerate set functions were moved to the new clock.c file.
      Signed-off-by: default avatarDaniel Mack <>
      Signed-off-by: default avatarTakashi Iwai <>
  24. 27 May, 2010 1 commit
  25. 29 Mar, 2010 1 commit
  26. 12 Mar, 2010 1 commit
  27. 05 Mar, 2010 4 commits