From 6343bbce3b8cacd98206fa83e77874213b659d4f Mon Sep 17 00:00:00 2001
From: Jelle van der Waa <jelle@archlinux.org>
Date: Wed, 14 Aug 2024 17:30:46 +0200
Subject: [PATCH] Re-use the same component instance for open and closed state
The conditional if is unrequired as we can pass `isOpen` to the `open`
property.
---
src/Section.js | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/Section.js b/src/Section.js
index 7208599..ed2b787 100644
--- a/src/Section.js
+++ b/src/Section.js
@@ -4,7 +4,7 @@ const React = require('react');
import Collapsible from 'react-collapsible'
function StatusSection(props) {
- const isOpen = props.open;
+ const isOpen = props.open || false;
const content = (
<ul>
{props.pkgs.map(function(pkg) {
@@ -32,10 +32,7 @@ function StatusSection(props) {
const label = `${props.label} (${props.pkgs.length})`;
return (
<div className={ props.label }>
- { isOpen
- ? <Collapsible trigger={label} lazyRender open>{ content }</Collapsible>
- : <Collapsible trigger={label} lazyRender>{ content }</Collapsible>
- }
+ <Collapsible trigger={label} lazyRender open={isOpen}>{ content }</Collapsible>
</div>
);
}
--
GitLab