Skip to content
GitLab
  1. 12 Aug, 2018 1 commit
    • Eli Schwartz's avatar
      Fix notifications emails going to the right people · b702e5c0
      Eli Schwartz authored and Lukas Fleischer's avatar Lukas Fleischer committed 
      In commit f3b4c5c6

 (Refactor the notification script, 2018-05-17), the
parameters of the adopt, disown, comaintainer-add and
comaintainer-remove notification modules were accidentally pushed around
without changing the order in the callers. The notify script now expects
to see the userid followed by additional arguments like the pkgbase id.

As a result, some random userid with the same id as the pkgbase, got
sent a notification regarding some package with the same id as the real
user's id.

Fix this by changing the order in every invocation of the aforementioned
modules.

Signed-off-by: Eli Schwartz's avatarEli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Lukas Fleischer's avatarLukas Fleischer <lfleischer@archlinux.org>
      b702e5c0
  3. 06 Aug, 2018 3 commits
  5. 09 Jul, 2018 1 commit
    • Eli Schwartz's avatar
      Fix regression in translating anything at all · c8d99bac
      Eli Schwartz authored and Lukas Fleischer's avatar Lukas Fleischer committed 
      In commit 840ee20f

 (Rename translation resources from aur to aurweb,
2018-07-07) the translations file was renamed but we never actually
switched to using the renamed translations.

As a result, every single push to the AUR contains the following
traceback:

    remote: Traceback (most recent call last):
    remote:   File "/usr/bin/aurweb-notify", line 11, in <module>
    remote:     load_entry_point('aurweb==4.7.0', 'console_scripts', 'aurweb-notify')()
    remote:   File "/usr/lib/python3.6/site-packages/aurweb-4.7.0-py3.6.egg/aurweb/scripts/notify.py", line 541, in main
    remote:   File "/usr/lib/python3.6/site-packages/aurweb-4.7.0-py3.6.egg/aurweb/scripts/notify.py", line 69, in send
    remote:   File "/usr/lib/python3.6/site-packages/aurweb-4.7.0-py3.6.egg/aurweb/scripts/notify.py", line 56, in get_body_fmt
    remote:   File "/usr/lib/python3.6/site-packages/aurweb-4.7.0-py3.6.egg/aurweb/scripts/notify.py", line 192, in get_body
    remote:   File "/usr/lib/python3.6/site-packages/aurweb-4.7.0-py3.6.egg/aurweb/l10n.py", line 14, in translate
    remote:   File "/usr/lib/python3.6/gettext.py", line 514, in translation
    remote:     raise OSError(ENOENT, 'No translation file found for domain', domain)
    remote: FileNotFoundError: [Errno 2] No translation file found for domain: 'aur'

Signed-off-by: Eli Schwartz's avatarEli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Lukas Fleischer's avatarLukas Fleischer <lfleischer@archlinux.org>
      c8d99bac
  7. 07 Jul, 2018 4 commits
  9. 20 May, 2018 1 commit
  11. 18 May, 2018 1 commit
    • Eli Schwartz's avatar
      git-update: accept any arch in arch-dependent metadata · 16795eaf
      Eli Schwartz authored and Lukas Fleischer's avatar Lukas Fleischer committed 
      

Currently we hardcode the architectures the official repos historically
supported, which seems both inefficient because of hardcoding, and
simply wrong, because many packages support various ARM platforms too.

If we were to say "only officially supported arches will be supported in
the AUR" we'd have to disable i686, which seems silly and arbitrarily
restrictive. Also there's better places to implement such a blacklist
(via die_commit in the main loop, via a config option to list supported
arches, would make much more sense in terms of logic).

As for the metadata extraction itself, there's no reason to hardcode the
arches to check for at all. We can get this information too, from the
.SRCINFO itself. Detecting this dynamically is not incompatible with a
blacklist, should we ever decide to implement such a thing.

Signed-off-by: Eli Schwartz's avatarEli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Lukas Fleischer's avatarLukas Fleischer <lfleischer@archlinux.org>
      16795eaf
  13. 17 May, 2018 5 commits
  15. 16 May, 2018 1 commit
  17. 12 May, 2018 4 commits
  19. 11 May, 2018 1 commit
    • Eli Schwartz's avatar
      Use a link to accept orphan requests · 0ffa0679
      Eli Schwartz authored and Lukas Fleischer's avatar Lukas Fleischer committed 
      

Currently, a form is used instead of a link. This forwards to a
confirmation page, and currently drops the "via" parameter in the
process.

As a result, accepted orphan requests usually show:

    Request #XXXXXX has been accepted automatically by the Arch User
    Repository package request system:

    The user YYYYYYY disowned the package.

This is wrong, and should show (will show, if you manually add it or use
the close button instead of the accept button):

    Request #XXXXXX has been rejected by YYYYYYY [1]:

Fixes FS#56606.

Signed-off-by: Eli Schwartz's avatarEli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Lukas Fleischer's avatarLukas Fleischer <lfleischer@archlinux.org>
      0ffa0679
  21. 10 May, 2018 2 commits
  23. 22 Apr, 2018 1 commit
    • Eli Schwartz's avatar
      config: allow reading both the defaults file and the modified config · 97c5bcec
      Eli Schwartz authored and Lukas Fleischer's avatar Lukas Fleischer committed 
      

In the process, rename config.proto to config.defaults (because that is
what it is now).

Also use dict.get('key', default_value) when querying os.environ, rather
than an if block, as it is more pythonic/readable/concise, and reduces
the number of dict lookups.

This change allows aurweb configuration to be done via either:
- copying config.defaults to config and modifying values
- creating a new config only containing modified values, next to a
  config.defaults containing unmodified values

The motivation for this change is to enable ansible configuration in our
flagship deployment by storing only changed values, and deferring to
config.defaults otherwise.

A side benefit is, it is easier to see what has changed by inspecting
only the site configuration file.

If a config.defaults file does not exist next to $AUR_CONFIG or in
$AUR_CONFIG_DEFAULTS, it is ignored and *all* values are expected to
live in the modified config file.

Signed-off-by: Eli Schwartz's avatarEli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Lukas Fleischer's avatarLukas Fleischer <lfleischer@archlinux.org>
      97c5bcec
  25. 08 Apr, 2018 1 commit
  27. 21 Mar, 2018 1 commit
  29. 20 Mar, 2018 1 commit
  31. 14 Mar, 2018 2 commits
  33. 13 Mar, 2018 1 commit
  35. 10 Mar, 2018 2 commits
  37. 24 Feb, 2018 4 commits
  39. 26 Jan, 2018 1 commit
  41. 21 Jan, 2018 1 commit
  43. 23 Dec, 2017 1 commit