Skip to content
  • Mandeep Baines's avatar
    forcedeth: Improve stats counters · 0bdfea8b
    Mandeep Baines authored
    
    
    Rx byte count was off; instead use the hardware's count.  Tx packet
    count was counting pre-TSO packets; instead count on-the-wire packets.
    Report hardware dropped frame count as rx_fifo_errors.
    
    - The count of transmitted packets reported by the forcedeth driver
      reports pre-TSO (TCP Segmentation Offload) packet counts and not the
      count of the number of packets sent on the wire. This change fixes
      the forcedeth driver to report the correct count. Fixed the code by
      copying the count stored in the NIC H/W to the value reported by the
      driver.
    
    - Count rx_drop_frame errors as rx_fifo_errors:
      We see a lot of rx_drop_frame errors if we disable the rx bottom-halves
      for too long.  Normally, rx_fifo_errors would be counted in this case.
      The rx_drop_frame error count is private to forcedeth and is not
      reported by ifconfig or sysfs.  The rx_fifo_errors count is currently
      unused in the forcedeth driver.  It is reported by ifconfig as overruns.
      This change reports rx_drop_frame errors as rx_fifo_errors.
    
    Signed-off-by: default avatarDavid Decotigny <david.decotigny@google.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    0bdfea8b