Skip to content
  • Harshad Shirwadkar's avatar
    ext4: clean up the JBD2 API that initializes fast commits · a1e5e465
    Harshad Shirwadkar authored
    
    
    This patch removes jbd2_fc_init() API and its related functions to
    simplify enabling fast commits. With this change, the number of fast
    commit blocks to use is solely determined by the JBD2 layer. So, we
    move the default value for minimum number of fast commit blocks from
    ext4/fast_commit.h to include/linux/jbd2.h. However, whether or not to
    use fast commits is determined by the file system. The file system
    just sets the fast commit feature using
    jbd2_journal_set_features(). JBD2 layer then determines how many
    blocks to use for fast commits (based on the value found in the JBD2
    superblock).
    
    Note that the JBD2 feature flag of fast commits is just an indication
    that there are fast commit blocks present on disk. It doesn't tell
    JBD2 layer about the intent of the file system of whether to it wants
    to use fast commit or not. That's why, we blindly clear the fast
    commit flag in journal_reset() after the recovery is done.
    
    Suggested-by: default avatarJan Kara <jack@suse.cz>
    Signed-off-by: default avatarHarshad Shirwadkar <harshadshirwadkar@gmail.com>
    Link: https://lore.kernel.org/r/20201106035911.1942128-7-harshadshirwadkar@gmail.com
    
    
    Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
    a1e5e465