Commit 9ac0934b authored by Dan Carpenter's avatar Dan Carpenter Committed by Dave Airlie
Browse files

drm: crtc: integer overflow in drm_property_create_blob()

The size here comes from the user via the ioctl, it is a number between
1-u32max so the addition here could overflow on 32 bit systems.

Fixes: f453ba04

 ('DRM: add mode setting support')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarDaniel Stone <daniels@collabora.com>
Cc: stable@kernel.org # v4.2
Signed-off-by: default avatarDave Airlie <airlied@gmail.com>
parent 04ccb890
...@@ -4105,7 +4105,7 @@ drm_property_create_blob(struct drm_device *dev, size_t length, ...@@ -4105,7 +4105,7 @@ drm_property_create_blob(struct drm_device *dev, size_t length,
struct drm_property_blob *blob; struct drm_property_blob *blob;
int ret; int ret;
if (!length) if (!length || length > ULONG_MAX - sizeof(struct drm_property_blob))
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
blob = kzalloc(sizeof(struct drm_property_blob)+length, GFP_KERNEL); blob = kzalloc(sizeof(struct drm_property_blob)+length, GFP_KERNEL);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment