Commit a54c4613 authored by Theodore Ts'o's avatar Theodore Ts'o
Browse files

ext4: fix race writing to an inline_data file while its xattrs are changing

The location of the extended attribute can change whenever
xattr_sem is not taken.  So we need to recalculate the i_inline_off
field since it mgiht have changed between ext4_write_begin() and

This means that caching i_inline_off is probably not helpful, so in
the long run we should probably get rid of it and shrink the in-memory
ext4 inode slightly, but let's fix the race the simple way for now.

Fixes: f19d5870

 ("ext4: add normal write support for inline data")
Signed-off-by: default avatarTheodore Ts'o <>
parent b33d9f59
......@@ -750,6 +750,12 @@ int ext4_write_inline_data_end(struct inode *inode, loff_t pos, unsigned len,
ext4_write_lock_xattr(inode, &no_expand);
* ei->i_inline_off may have changed since ext4_write_begin()
* called ext4_try_to_write_inline_data()
(void) ext4_find_inline_data_nolock(inode);
kaddr = kmap_atomic(page);
ext4_write_inline_data(inode, &iloc, kaddr, pos, len);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment