Commit a802ea96 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

cpuidle: Check the sign of index in cpuidle_reflect()

Avoid calling the governor's ->reflect method if the state index
passed to cpuidle_reflect() is negative.

This allows the analogous check to be dropped from menu_reflect(),
so do that too, and ensures that arbitrary error codes can be
passed to cpuidle_reflect() as the index with no adverse

Signed-off-by: default avatarRafael J. Wysocki <>
Reviewed-by: default avatarDaniel Lezcano <>
Acked-by: default avatarPeter Zijlstra (Intel) <>
parent 82f66327
......@@ -249,7 +249,7 @@ int cpuidle_enter(struct cpuidle_driver *drv, struct cpuidle_device *dev,
void cpuidle_reflect(struct cpuidle_device *dev, int index)
if (cpuidle_curr_governor->reflect)
if (cpuidle_curr_governor->reflect && index >= 0)
cpuidle_curr_governor->reflect(dev, index);
......@@ -367,9 +367,9 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev)
static void menu_reflect(struct cpuidle_device *dev, int index)
struct menu_device *data = this_cpu_ptr(&menu_devices);
data->last_state_idx = index;
if (index >= 0)
data->needs_update = 1;
data->needs_update = 1;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment