- 04 Jan, 2017 1 commit
-
-
Allan McRae authored
Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 05 Dec, 2016 1 commit
-
-
In FS#43434, Downloads which fail and are restarted on a different server will resume and may display a negative download speed. The payload's progress in libalpm was not properly reset which ultimately caused terminal noise because the line width calculation assumes positive download speeds. This patch fixes the incomplete reset of the payload by mimicing what be_sync.c:alpm_db_update() does over in sync.c:download_single_file(). The new dload.c:_alpm_dload_payload_reset_for_retry() extends beyond the current behavior by updating initial_size and prevprogress for this case. This makes pacman reset the progress properly in the next invocation of the callback and display positive download speeds. Fixes FS#43434. Signed-off-by:
Martin Kühne <mysatyre@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 22 Oct, 2016 2 commits
-
-
Many bitfield variables are declared to be enums, because they are generated using bitwise operations on enums such. However, their actual values aren't necessary members of their parent enum, so declaring them 'int' is more accurate. Signed-off-by:
Ivy Foster <ivy.foster@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
This allows functions which return an _alpm_errno_t to always return a genuine _alpm_errno_t for consistency, even in cases where there are no errors. Since ALPM_ERR_OK = 0, their callers can still simply check 'err = some_fn(); if (!err) { ... }'. Signed-off-by:
Ivy Foster <ivy.foster@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 23 Feb, 2016 1 commit
-
-
Relying on localdb to determine which trigger operations should match is completely broken for PostTransaction hooks because the localdb has already been updated. Store a copy of the old version of any packages being updated to use instead. Fixes FS#47996 Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 04 Jan, 2016 1 commit
-
-
Allan McRae authored
make update-copyright OLD=2015 NEW=2016 Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 20 Sep, 2015 1 commit
-
-
This is necessary in order to be able to run PreTransaction hooks as close to the actual commit as possible so that we don't prematurely run hooks for a transaction that ultimately never happens. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 20 Jul, 2015 1 commit
-
-
While loading each package ensure that the internal version matches the expected database version to avoid the possibility to circumvent the version check. This issue can be used by an attacker to trick the software into installing an older version. The behavior can be exploited by a man-in-the-middle attack through specially crafted database tarball containing a higher version, yet actually delivering an older and vulnerable version, which was previously shipped. Signed-off-by:
Levente Polyak <anthraxx@archlinux.org> Signed-off-by:
Remi Gacogne <rgacogne@archlinux.org> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 03 Mar, 2015 1 commit
-
-
Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 01 Feb, 2015 1 commit
-
-
Allan McRae authored
Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 27 Dec, 2014 1 commit
-
-
Allan McRae authored
Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 24 Dec, 2014 1 commit
-
-
Allan McRae authored
Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 13 Oct, 2014 1 commit
-
-
download_files sets the transaction state to STATE_DOWNLOADING. Modifying the state after it has already been set to STATE_COMMITTING created a brief window where SIGINT would fail to interrupt the process and caused interrupted downloads to result in a 'transaction started' message in the log with no matching transaction end. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com>
-
- 30 Sep, 2014 3 commits
-
-
Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com>
-
The retry path was removed by 4ccf16df Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com>
-
Signed-off-by:
Florian Pritz <bluewind@xinu.at>
-
- 03 Aug, 2014 1 commit
-
-
Since 017184fa , alpm_sync_sysupgrade will not add both a replacement and a literal upgrade to the transaction. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 24 Jun, 2014 1 commit
-
-
Much like with events, instead of using a bunch of void* arguments for all questions, we now send one pointer to an alpm_question_t union. This contains the type of question that was triggered. With this information, a question-specific struct can be accessed in order to get additional arguments. Signed-off-by:
Olivier Brunel <jjk@jjacky.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 08 Mar, 2014 1 commit
-
-
Allan McRae authored
Use MALLOC instead of malloc for safety in libalpm. Some changes are pure refactoring, but for others this provides a success check for memory allocation. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 04 Mar, 2014 1 commit
-
-
Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 03 Mar, 2014 4 commits
-
-
Allan McRae authored
Signed-off-by:
Allan McRae <allan@archlinux.org>
-
These will be emmitted when download a package file from a repository, indicating that the download starts, and whether it was successfull or not. Note that when multiple servers are available, no event is emmitted when switching to another server. (This doesn't apply to alpm_fetch_pkgurl(), but since it is called by the frontend, it shouldn't have problems knowing when the download starts and when it ends.) Signed-off-by:
Olivier Brunel <jjk@jjacky.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
To go along with RETRIEVE_START, one other event will be emmitted once the downloads are done: RETRIEVE_DONE if all files were successfully downloaded, else RETRIEVE_FAILED. Signed-off-by:
Olivier Brunel <jjk@jjacky.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Instead of using two void* arguments for all events, we now send one pointer to an alpm_event_t struct. This contains the type of event that was triggered. With this information, the pointer can then be typecasted to the event-specific struct in order to get additional arguments. Signed-off-by:
Olivier Brunel <jjk@jjacky.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 07 Feb, 2014 1 commit
-
-
If the user opted not to remove the unresolvable packages from the transaction, the list was neither free'd nor saved to the transaction to be free'd in trans_release. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 04 Feb, 2014 1 commit
-
-
Front-ends should be able to free memory that alpm hands them. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 30 Jan, 2014 1 commit
-
-
_alpm_resolvedeps resets pm_errno to 0 by calling alpm_checkdeps. Whenever the last call succeeded, pm_errno was not properly set, preventing pacman from properly handling the error and leaking additional memory. We know pm_errno should be ALPM_ERR_UNSATISFIED_DEPS if resolvedeps has failed, so just set it manually. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 28 Jan, 2014 1 commit
-
-
Forcing vim users to view files with a tabstop of 2 seems really unnecessary when noet is set. I find it much easier to read code with ts=4 and I dislike having to override the modeline by hand. Command run: find . -type f -exec sed -i '/vim.* noet/s# ts=2 sw=2##' {} + Signed-off-by:
Florian Pritz <bluewind@xinu.at> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 15 Jan, 2014 1 commit
-
-
We only care that packages are being installed from a repo, not how many. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 10 Jan, 2014 1 commit
-
-
Allan McRae authored
Fix the occurances of #if to be #ifdef for consistency.
-
- 06 Jan, 2014 2 commits
-
-
Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 19 Dec, 2013 1 commit
-
-
Packages can be removed during a sync transaction either directly or due to conflicts and need to be sorted. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 15 Dec, 2013 2 commits
-
-
Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 31 Oct, 2013 3 commits
-
-
Detecting indirect dependencies by traversing a package's entire dependency tree is prohibitively slow for larger transactions. Instead add local packages to the dependency graph. This additionally requires delaying dependency ordering for sync operations so that removed packages may be excluded from dependency detection. tests/sync012.py was also updated to ensure that the dependency cycle was actually detected. Fixes FS#37380 Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
This function is useful for frontends to annotate package upgrades that will be ignored. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
These are useful for frontends. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 15 Oct, 2013 2 commits
-
-
Allan McRae authored
On 32bit systems, the progress bar intergrity checking can show values greater than 100% with large transactions. This is due to the total size of all package files being greater than a size_t. Use uint64_t for these sizes. Fixes FS#36608 Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
If any package in a sync transaction is missing a required signature, we give an uninformative error message (which may or may not state that the missing signature is the issue). Always output the package with the missing signature. Signed-off-by:
Allan McRae <allan@archlinux.org>
-