- 21 Aug, 2013 18 commits
-
-
Allan McRae authored
These references to bug numbers assume we will forever be using that bug tracker. It is better to properly comment the code instead (which was done in almost all cases anyway). Signed-off-by:
Allan McRae <allan@archlinux.org>
-
The recursion limit is an artificial limitation imposed to prevent memory exhaustion in a recursive function. Giving it file-level scope increases its visibility. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
If an error in the main file would be fatal there is little reason to ignore the error in an included file. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
By the time we make the recursive call we have already finished with the line buffer, making it safe to reuse. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Move _parseconfig to ini.c as _parse_ini and create a convenient wrapper for the public API. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
This will allow passing arbitrary key/value handlers. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
_parseconfig now tracks the current section name directly so that the name stored in the section struct is just a pointer to the one stored by _parseconfig. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Include directives no longer have to be within a section. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
This consolidates all of our state information into a single variable. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
This functionality can be provided by a test harness. Having pactest output this information as well clutters the result log created by automake. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
This removes the --test switch, making it easier to call pactest from a test harness. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Our test scripts currently require that the first argument be the library or binary to be tested. This makes integrating them with automake which doesn't have a mechanism for passing specific arguments to individual tests. Instead, provide a default built from paths in the environment which can be provided to all test scripts by automake. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Each test produces a single TAP result with the rules run in a sub-test. This reduces output when run under automake and makes it possible to continue setting expectfailure at the test level rather than per-rule. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Tests should only be skipped when they aren't relevant, not when the test itself is bad. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Use the architecture of the python interpreter running the test to detect 32bit systems. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 30 Jul, 2013 14 commits
-
-
Allan McRae authored
When pacman failed to initialise the alpm library due to the database directory being missing (either via the root not existing or the database directory itself not existing), it just printed the non-informative message "could not find or read directory". Add the directory information the the error output. E.g.: error: failed to initialize alpm library (could not find or read directory: /this/does/not/exist/var/lib/pacman/) Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
Using setlocale in the backend is bound to lead to frontend issues and we have have been using epoch in our databases since April 2007 (commit 47622eef ). Remove support for old style times. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
We currently only warn if a directory's permissions differ, but using -Qkk on my system shows that directory permissions tend to change in packages reasonably frequently without notice. Provide a warning in such cases so that it can be altered. Example output: (1/1) reinstalling nginx warning: directory ownership differs on /var/lib/nginx/proxy/ filesystem: 33:0 package: 0:0 Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
Backup files are expected to be changed and should not be flagged by -Qkk. Note changed back-up files in -Qkk but do not count them as altered. Do not report backup files in -Qqkk. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Replace spaces with tabs in one instance. Remove extra spaces. Signed-off-by:
Jason St. John <jstjohn@purdue.edu> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Replace spaces with tabs. Remove extra spaces. Signed-off-by:
Jason St. John <jstjohn@purdue.edu> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
This is an option to just echo's the pacnews/pacsaves instead of merging or removing them. This can be used to check the config status such as in a cron job without modifying the system. Signed-off-by:
Jonathan Frazier <eyeswide@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Signed-off-by:
Jonathan Frazier <eyeswide@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
This is a new search type, using -p or --pacmandb options. It reads config file locations directly from the local pacman db. It will find active configs anywhere they are defined in installed packages. It is not dependant on outside configs such as updatedb.conf or scanning a large set of directories for find. This will find more pacnews than find when searching with the current default of /etc, and it is faster than both find and updatedb when searching the entire fs. When run directly after an update, the local db is more likely to be cached than all files in /etc or / as other methods read. This will increase performance further post upgrade. After a package is removed and a pacsave is created, this method will not find these pacsaves until the base config is added to the local db again. These files have no influence in a working system and only take up a few blocks of disk space. Active configs need to be dealt with immediately to keep a system working. pacsaves related to removed configs can remain for weeks or months without problems. I would recommend occasionally running other methods such as --locate to remove them. Signed-off-by:
Jonathan Frazier <eyeswide@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Change cmd tests to if (( USE_FIND ))... as it is cleaner. All search cmds have an option and a variable initialized to zero. The active option should be set to 1. Add a switch to exclude multiple search options. set the default when all are equal to zero. Signed-off-by:
Jonathan Frazier <eyeswide@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allow colors to be disabled for use on broken/serial terminals. Signed-off-by:
Jonathan Frazier <eyeswide@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
loop over arguments, this will allow adding options such as --nocolor Signed-off-by:
Jonathan Frazier <eyeswide@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Clean up and reword --help get rid of all the echos to make it easier to read in source. Signed-off-by:
Jonathan Frazier <eyeswide@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Signed-off-by:
Jonathan Frazier <eyeswide@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 22 Jul, 2013 8 commits
-
-
Non-zero is now returned if a group is searched for that doesn't exist. Fixes FS#36097. Signed-off-by:
Ashley Whetter <awhetter.2011@my.bristol.ac.uk> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Signed-off-by:
Zulker Nayeen Nahiyan <nahiyan02@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
Use a clear message rather than using a made up word to describe what we are doing. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Fixes FS#31557 Signed-off-by:
Ashley Whetter <awhetter.2011@my.bristol.ac.uk> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Signed-off-by:
Jonathan Frazier <eyeswide@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
On systems without gpgme installed, autoreconf will fail with an unrelated error message unless the gpgme.m4 file is present. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
Use 'git clean' instead. Signed-off-by:
Allan McRae <allan@archlinux.org>
-