1. 21 Jan, 2011 2 commits
  2. 12 Jan, 2011 4 commits
    • Dan McGee's avatar
      Fix double read issue in maint releases · 30f53cfe
      Dan McGee authored
      This is essentially a backport/cherry-pick of commit 33240e87
      master, but has to be done by hand because the DB format has diverged. Read
      more in the commit message used there, which follows.
      Due to the way we funk around with package data loading, we had a condition
      where the filelist got doubled up because it was loaded twice.
      Packages are originally loaded with INFRQ_BASE. In an upgrade/sync, the
      package is checked for file conflicts next, leaving us in an "INFRQ_BASE |
      INFRQ_FILES" state. Later, when committing a single package, we have an
      explicit call to _alpm_local_db_read() with INFRQ_ALL as the level. Because
      the package's level did not match this, we skipped over our previous "does
      the incoming level match where I'm at" shortcut, and continued to load
      things again, because of a lack of fine-grained checking for each of DESC,
      FILES, and INSTALL.
      The end result is we loaded the filelist twice, causing our remove logic to
      iterate twice over the installed files, spewing a bunch of "cannot find file
      X" messages.
      Fix the problem by doing a bit more bitmasking logic throughout the load
      method, and also fix the sanity check at the beginning of the function- this
      should *only* be used for local packages as opposed to the "not a package"
      check that was there before.
      Signed-off-by: default avatarDan McGee <dan@archlinux.org>
    • Dan McGee's avatar
      pactest: build the filelist using a set() · cae2bdaf
      Dan McGee authored
      This will prevent duplicates, which we had plenty of once I made a few tests
      that had a list of files greater than the normal two. The previous logic was
      not working quite right.
      Signed-off-by: default avatarDan McGee <dan@archlinux.org>
      (cherry picked from commit 0d4dd099)
    • Dan McGee's avatar
    • Dan McGee's avatar
      Back out anticipated epoch changes · 9e8af82c
      Dan McGee authored
      After all the debate as to what to do on maint, we are going to end up just
      incorporating epoch into the version string, so we don't need this separate
      field at all. Revert commit 5c8083ba
       and also kill the force flag we were
      recording here as well.
      Signed-off-by: default avatarDan McGee <dan@archlinux.org>
  3. 30 Dec, 2010 5 commits
  4. 14 Dec, 2010 2 commits
  5. 13 Dec, 2010 2 commits
  6. 11 Dec, 2010 1 commit
    • Dan McGee's avatar
      Fix possible null pointer deref in check_arch · eedf4f4e
      Dan McGee authored
      If we have a corrupted database, a package can come through without an arch,
      causing the code to blow up when making strcmp() calls. It might even be
      possible with perfectly valid database entries lacking an 'arch =' line.
      This behavior was seen as at least one of the problems in FS#21668.
      Ensure pkgarch is not null before doing anything further.
      Signed-off-by: default avatarDan McGee <dan@archlinux.org>
  7. 08 Nov, 2010 1 commit
  8. 28 Oct, 2010 4 commits
  9. 18 Oct, 2010 2 commits
    • Xavier Chantry's avatar
      alpm/sync: very small memleak fix · 30734c9a
      Xavier Chantry authored
      Signed-off-by: default avatarXavier Chantry <chantry.xavier@gmail.com>
      Signed-off-by: default avatarDan McGee <dan@archlinux.org>
    • Xavier Chantry's avatar
      libalpm/remove: fix funny progress bar problem with empty packages · a2d7f6f2
      Xavier Chantry authored
      $ pacman -Rd kde-meta
      Remove (15): kde-meta-kdewebdev-4.5-1 [0.00 MB]  kde-meta-kdeutils-4.5-1 [0.00 MB]
                   kde-meta-kdetoys-4.5-1 [0.00 MB]  kde-meta-kdesdk-4.5-1 [0.00 MB]
                   kde-meta-kdeplasma-addons-4.5-1 [0.00 MB]  kde-meta-kdepim-4.5-1 [0.00 MB]
                   kde-meta-kdenetwork-4.5-1 [0.00 MB]  kde-meta-kdemultimedia-4.5-1 [0.00 MB]
                   kde-meta-kdegraphics-4.5-1 [0.00 MB]  kde-meta-kdegames-4.5-1 [0.00 MB]
                   kde-meta-kdeedu-4.5-1 [0.00 MB]  kde-meta-kdebase-4.5-1 [0.00 MB]
                   kde-meta-kdeartwork-4.5-1 [0.00 MB]  kde-meta-kdeadmin-4.5-1 [0.00 MB]
                   kde-meta-kdeaccessibility-4.5-1 [0.00 MB]
      Total Removed Size:   0.06 MB
      Do you want to remove these packages? [Y/n]
      ( 1/15) removing kde-meta-kdewebdev      [------------------------] 100%
      $ it stopped here..
      On one side, libalpm did not initialize the progress bar at 0 percent.
      So with meta-packages that have 0 files, there was only one progress bar
      call with percent == 100.
      On the other side, pacman callback kept track of the last percent that
      it received. When there are only meta-packages, we always received only
      100, so pacman believed the progress bar needed not update. Thus only
      the first package was actually displayed.
      A proper fix for the callback would be to keep track of last package
      name to make sure the recorded prev percent applies.
      But since we now specify that both Add and Remove should at least send
      percent=0 at beginning and percent=100 at the end, there is no need
      for that.
      Signed-off-by: default avatarXavier Chantry <chantry.xavier@gmail.com>
      Signed-off-by: default avatarDan McGee <dan@archlinux.org>
  10. 11 Oct, 2010 1 commit
    • Dan McGee's avatar
      Read 'force' entry from packages · 3a06a9fa
      Dan McGee authored
      We weren't reading this in from our packages, thus causing us not to write
      it out to our local database. Adding this now will help ease the upgrade
      path for epoch later and not require reinstallation of all force packages.
      Signed-off-by: default avatarDan McGee <dan@archlinux.org>
  11. 05 Oct, 2010 2 commits
  12. 15 Sep, 2010 4 commits
  13. 04 Sep, 2010 3 commits
  14. 02 Sep, 2010 5 commits
  15. 27 Aug, 2010 1 commit
  16. 25 Aug, 2010 1 commit