- 05 Dec, 2016 16 commits
-
-
In FS#43434, Downloads which fail and are restarted on a different server will resume and may display a negative download speed. The payload's progress in libalpm was not properly reset which ultimately caused terminal noise because the line width calculation assumes positive download speeds. This patch fixes the incomplete reset of the payload by mimicing what be_sync.c:alpm_db_update() does over in sync.c:download_single_file(). The new dload.c:_alpm_dload_payload_reset_for_retry() extends beyond the current behavior by updating initial_size and prevprogress for this case. This makes pacman reset the progress properly in the next invocation of the callback and display positive download speeds. Fixes FS#43434. Signed-off-by:
Martin Kühne <mysatyre@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Signed-off-by:
Christian Hesse <mail@eworm.de> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
libalpm's local database format does not support paths with newlines. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allows lint_package to prevent makepkg from creating an invalid package. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
The PKGINFO format cannot handle values that contain newlines. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Neither function was checking for the existence of actual results before calling printf, resulting in them returning a list with a single empty value if there were no depends/provides. Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
This does exactly the same thing as it code it replaces, but punt to curl to do it for brevity. Requires curl 7.25.0, which we already cover. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
I'm not convinced this is a worthwhile goal, but let's follow suit. Since we can't know the names of all the vars that might exist, unset them by pattern.
-
-
The inside needs quoting, and this is separate from the declartion, which does not (in these cases).
-
Use shopt to set/reset errexit and errtrace, which lets us: 1) be more vigilant, resetting anything the user might do to us in PKGBUILD functions. 2) use human-readable words (errexit vs. -e) On top of this, introduce a new save/restore for the shell's other shopts. A user should not have any expectations that what happens in one function is available in another function, if it isn't explicitly defined in the PKGBUILD. While this change does not make that assertion, it gets us closer. We also replace a variable which comes from out of nowhere (pkgfunc) with the positional parameter containing the same value. Quoting is adjusted to make the expansion happen at the time the trap is set, rather than later on.
-
These 'set +E' diversions haven't been needed since global errexit was disabled in dca10b06 (January 2012).
-
This disables globbing, which should never be used in source URL specifications as it would lead to mismatches in the checksum mapping and un-checked sources.
-
After 1f8f0bd9 all scripts that were changed to using the wrapper for in-tree use have the wrappers installed to the system instead of the actual script, so change the install command to support all wrapped scripts instead of just makepkg. Signed-off-by:
Johannes Löthberg <johannes@kyriasis.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
Moved to the pacman-contrib project Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
This reverts commit a79c0038. I merged the wrong branch into master...
-
- 02 Nov, 2016 1 commit
-
-
Allan McRae authored
Debug packages are fairly useless currently because the soucre files needed for stepping through code etc are not packaged with them. This patch adds the needed source files to the debug package and adjusts the debug info to look at the /usr/src/debug/ directory for them rather than the build location. This requires using the "debugedit" program which is provided as part of the RPM sources. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 22 Oct, 2016 10 commits
-
-
Many bitfield variables are declared to be enums, because they are generated using bitwise operations on enums such. However, their actual values aren't necessary members of their parent enum, so declaring them 'int' is more accurate. Signed-off-by:
Ivy Foster <ivy.foster@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
This allows functions which return an _alpm_errno_t to always return a genuine _alpm_errno_t for consistency, even in cases where there are no errors. Since ALPM_ERR_OK = 0, their callers can still simply check 'err = some_fn(); if (!err) { ... }'. Signed-off-by:
Ivy Foster <ivy.foster@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Though correct, the wording of the description of Query's -t/--unrequired option was confusing. Closes FS#48144. Signed-off-by:
Ivy Foster <ivy.foster@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Since rewriting build_references() anyway, tweaked quoting. Implements FS#31558. Signed-off-by:
Ivy Foster <ivy.foster@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
This has been moved to the pacman-contrib project. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
If pacman is build against a crypto library other than openssl, it makes no sense to require makepkg to use it. The only currently considered alternative to openssl is nettle, which has no binary for base64 encode/decode. This means that we could replace the hashing cacluations with nettle-hash, but would require base64 from coreutils. Given makepkg already relies heavily on coreutils, we might as well use all the coreutils hashing binaries too. This patch also improves the checking of required binaries for hashing operations. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Add a --with-nettle configure option that directs pacman to use the libnettle hashing functions. Only one of the --with-libssl and --with-nettle configure options can be specified. [Allan: rewrote configure check] Signed-off-by:
Allan McRae <allan@archlinux.org>
-
parseopts is used in makepkg and other scripts such as pacman-key as a getopt replacement. Instead of including it in those scripts via a macro, move it to libmakepkg/util/parseopts.sh and have scripts source this file where appropriate. To keep the parseopts test, a new variable was introduced: PM_LIBMAKEPKG_DIR Signed-off-by:
Alad Wenter <alad@archlinux.info> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
Signed-off-by:
Allan McRae <allan@archlinux.org>
-
In order for the scripts to be used in testsuites, it is easiest to generate all of them so they are found in the build directory (which may be different to the source directory). Signed-off-by:
Alad Wenter <alad@archlinux.info> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 12 Oct, 2016 1 commit
-
-
This should make pacman's behavior consistent with GNU coreutils df, as well as follow advice from affected filesystems' devs as well as `man statvfs`. This fixes FS#37402 Signed-off-by:
Martin Kühne <mysatyre@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 11 Oct, 2016 1 commit
-
-
Allan McRae authored
makepkg-wrapper did not get rebuilt if makepkg was regenerated due to library changes. Ensure makepkg-wrapper is always generated and linked any time makepkg changes. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 10 Oct, 2016 7 commits
-
-
We checked for empty array elements, but did not catch empty array. Add a check for that case as well. Signed-off-by:
Christian Hesse <mail@eworm.de> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
The contrib directory takes too much of the pacman developer's limited time, which could be better spent developing and reviewing patches for the primary projects. The community can pick this up in a separate repository if wanted. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
The people who believe that pacman-optimize is actually doing something useful are the same people who are voting for Trump. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
This fixes the issue with --printsrcinfo that all arch specific variants of a variable get merged into their non arch specific variant. The .SRCINFO file ends up having $depends containing $depends_x86_64 and omitting the latter. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
This was included due to use of PolarSSL's implementation for our internal SHA2 support. As our internal checksum calculations are now removed, we can also remove this unused code path. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Allan McRae authored
The internal implementations for md5 and sha256 checksums have not been merged from upstream sources for a long time. Instead of us carrying copies of code from other projects, we should just support building against multiple libraries that provide such functionality. This patch removes the md5 and sha2 code (originally obtained from PolarSSL) from our repository. The configure script will now error unless at least one library supporting checksum generation is present, with the only library currently supported being openssl. It will be relatively simple for other such libraries (e.g. nettle) to be supported if anyone wishes to add them. Signed-off-by:
Allan McRae <allan@archlinux.org>
-
- 25 Sep, 2016 4 commits
-
-
Signed-off-by:
Ivy Foster <ivy.foster@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Signed-off-by:
Gordian Edenhofer <gordian.edenhofer@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Signed-off-by:
Gordian Edenhofer <gordian.edenhofer@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-
Signed-off-by:
Gordian Edenhofer <gordian.edenhofer@gmail.com> Signed-off-by:
Allan McRae <allan@archlinux.org>
-