- 05 May, 2020 2 commits
-
-
Allan McRae authored
This reverts commit d7639a14.
-
Allan McRae authored
-
- 02 May, 2020 3 commits
-
-
Allan McRae authored
-
Allan McRae authored
Add CI See merge request pacman/pacman!1
-
Sven-Hendrik Haase authored
-
- 29 Apr, 2020 2 commits
-
-
This is useful for dumb terminals that do not support escape sequences. Signed-off-by:
Ivy Foster <escondida@iff.ink>
Signed-off-by: Allan McRae <allan@archlinux.org>
-
Signed-off-by:
Rikard Falkeborn <rikard.falkeborn@gmail.com> Signed-off-by:
-
- 15 Apr, 2020 2 commits
-
-
Allan McRae authored
Signed-off-by: -
Version colour numbers are dulled in the non-verbose transaction summary when colours are enabled. To prevent a regression, this patch also adds handling of strings with ANSI codes to string_length as to not break the transaction summary's output functions when colour codes are in the package name strings. Signed-off-by:
Carson Black <uhhadd@gmail.com> Signed-off-by:
-
- 13 Apr, 2020 4 commits
-
-
Allan McRae authored
The GOTO_ERR define was added in commit 80ae8014 for use in future commits. There are plenty of places in the code base it can be used, so convert them. Signed-off-by:
-
Allan McRae authored
Use STRDUP() over strdup() to catch memory allocation errors. There are still some instances of strdup left, but these are in functions that currently have no error path and would require a larger rework. Signed-off-by: -
realloc can fail just like the other memory allocation functions. Add a macro to simplify handling of realloc failures, similar to the already existing MALLOC, CALLOC, etc. Replace the existing realloc uses with the new macro, allowing us to move tedious error handling to the macro. Also, in be_package and be_sync, this fixes hypothetical memory leaks (and thereafter null pointer dereferences) in case realloc fails to shrink the allocated memory. Signed-off-by:
-
Current code accidently uses noupgrade for the NoExtract directive. Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by:
-
- 13 Mar, 2020 2 commits
-
-
Use ASCII control codes to hide cursor at the pacman start and then show the cursor when pacman finishes. It helps to avoid annoying blinking when progress bars are re-drawn. Cursor is reenabled if pacman expects user's input. Signed-off-by:
Anatol Pomozov <anatol.pomozov@gmail.com>
Signed-off-by: -
Allan McRae authored
Following the example of the recently added GOTO_ERR, adding the file and line number in addition to the function name in our debug messages is potentially useful. Signed-off-by:
-
- 09 Mar, 2020 2 commits
-
-
This is a macro similar to RET_ERR but useful in the case when we need to record an error and then jump to some cleanup section. Signed-off-by:
Anatol Pomozov <anatol.pomozov@gmail.com>
Signed-off-by: -
Allan McRae authored
Since commit 2ee7a8d8 , there is no cleanup needed in this function. Just return instead of jumping to the cleanup label. Signed-off-by:
-
- 05 Mar, 2020 2 commits
-
-
'output' is a list of messages that pacman received but delayed printing to avoid messing with UI. Such functionality is useful for the upcoming multi-line progress bar UI. Let's move it to a separate function. Signed-off-by:
Anatol Pomozov <anatol.pomozov@gmail.com>
Signed-off-by: -
One reason why the function returns an error is some repo does not have any servers. Signed-off-by:
Anatol Pomozov <anatol.pomozov@gmail.com>
Signed-off-by:
-
- 24 Feb, 2020 1 commit
-
-
Currently, download_files() creates payloads for all packages then iterates over them, calling download_single_file. This can be simplified by looping over packages and constructing the payload as needed. Signed-off-by:
Anatol Pomozov <anatol.pomozov@gmail.com>
Signed-off-by:
-
- 12 Feb, 2020 1 commit
-
-
When pacman fails to satisfy deps, we might see output like the following: ==> Making package: spiderfoot 3.0-1 (Thu 06 Feb 2020 12:45:10 PM CET) ==> Checking runtime dependencies... ==> Installing missing dependencies... error: target not found: python-pygexf ==> ERROR: 'pacman' failed to install missing dependencies. ==> Missing dependencies: -> python-dnspython -> python-exifread -> python-cherrypy -> python-beautifulsoup4 -> python-netaddr -> python-pysocks -> python-ipwhois -> python-ipaddress -> python-phonenumbers -> python-pypdf2 -> python-stem -> python-whois -> python-future -> python-pyopenssl -> python-docx -> python-pptx -> python-networkx -> python-cryptography -> python-secure -> python-pygexf -> python-adblockparser ==> Checking buildtime dependencies... ==> ERROR: Could not resolve all dependencies. This is misleading -- the only truly missing package is python-pygexf, but we fail to remove sync-able deps from our deplist and report everything as if it were missing. Simply drop this extra reporting because pacman already tells us exactly what couldn't be resolved. Signed-off-by:
-
- 10 Feb, 2020 2 commits
-
-
Allan McRae authored
Signed-off-by: -
Allan McRae authored
Improve discoverability of the alpm-hooks man page by adding a pacman-hooks symlink. Signed-off-by:
-
- 30 Jan, 2020 1 commit
-
-
Current flow looks like loop dbs_sync { loop pkgs { if pkg.db == db then process(pkg, db) } } Package sync transaction always has a counterpart in the dbs_sync list (I cannot come up with a use-case when it is not true). So the loop can be simplified to: loop pkgs { process(pkg, pkg.db) } Tested: 'ninja test' & manually by using pacman with this patch for a week Signed-off-by:Anatol Pomozov <anatol.pomozov@gmail.com>
Signed-off-by:
-
- 28 Jan, 2020 4 commits
-
-
libalpm: move docs from .c files into alpm.h And fix/expand some along the way. Signed-off-by: -
It looks like this function has never actually worked. The current list is never set to NULL after being freed. So the new deps were just appended to the already freed list, leading to a segfault. Signed-off-by: -
Allan McRae authored
Checksums arrays should be filled with values provided by upstream. We currently have md5 set as an unsecure default, and are constantly asked to change it to sha2. However, just changing the default to a stronger checksum gives the user the impression that "makepkg -g" checksums are perfect. Instead, change the default checksum to a CRC, to make it clear that any checksum generated purely by "makepkg -g" is not ideal. Signed-off-by: -
Allan McRae authored
Generating checksums with "makepkg -g" only determines that the user of a PKGBUILD has the same file as the packager (assuming no collision). This means an upstream source could be maliciously changed and passed on as valid by a PKGBUILD. To avoid this, it is essential that any checksums used in a PKGBUILD are as provided by upstream. Signed-off-by:
-
- 27 Jan, 2020 6 commits
-
-
Allan McRae authored
Commit e6a6d307 detected complete part files by comparing a payload's max_size to initial_size. However, these values are also equal when we use pacman -U on a URL as max_size is set to 0 in that case. Add a further condition to avoid that. Signed-off-by:
-
Extracting function variables containing arbitrarily scoped variables of arbitrary nature is a disaster, but let's at least cover the common case of using the actual '$pkgname' in an install/changelog file. It's the odd case of actually being basically justified use of disambiguating between the same variable used in multiple different split packages... and also, --printsrcinfo already uses and overwrites the variable 'pkgname' in pkgbuild_extract_to_srcinfo, so this "works" in .SRCINFO but doesn't work in .src.tar.gz It doesn't work in lint_pkgbuild either, but in that case the problem is being too permissive, not too restrictive -- we might end up checking the same file twice, and printing that it is missing twice. Fixes FS#64932 Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
Allan McRae authored
We previously has the maximum database size as 25MB. This was set in the days before repos had as many packages as they do now, and before we started distributing files databases. Increase this limit to 128MB. Signed-off-by: -
Allan McRae authored
Many moons ago, libtool was bad - I mean worse than today! It gobbled all --as-needed and we ended up with an overlinked libalpm. This was annoying, particularly when dealing with soname bumps in libraries pacman/libalpm had no business linking to. Luckily we had a fix, stolen from GNOME I believe. And with that fix, we lived in harmony with libtool for many years. Until one day, unbeknownst to us, libtool was "fixed". We kept applying our patch, because it still applied, but it did worse than nothing. It gobbled up our other LDFLAGS, and our libalpm started missing out on RELRO and BIND_NOW. This made the Arch Security Team unhappy. We will make them happy again by stopping the patch. Signed-off-by: -
Allan McRae authored
Running the testsuite using "PACTEST_VALGRIND=1 ninja test -C build", I ran into the following failure: 161/332 smoke001.py TIMEOUT 30.02 s I figure an i7 @ 3.10GHz should be enough to run our testsuite... so boost the meson test timeout to 120 seconds (which should be enough time for anyone...). Signed-off-by: -
Allan McRae authored
-
- 07 Jan, 2020 5 commits
-
-
It's difficult to find it embedded inside a prose paragraph. Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
Currently, it could be misread to say that a fragment is literally 'commit', rather than 'commit=somehash'. Anecdotally this does not seem to be obvious to everyone, and rewording it certainly doesn't hurt. Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
Forbid the AX_COMPARE_VERSION macro from being found in the output configure script. If autoconf-archive is not installed when autoreconf is run, the following error message is emitted: configure.ac:231: error: possibly undefined macro: AX_COMPARE_VERSION If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. autoreconf: /usr/bin/autoconf failed with exit status: 1 Signed-off-by:Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
This is guaranteed less error prone than calling memset and hoping the human gets the argument order correct.
-
This avoids a crash in filetarget_free() when regex support isn't requested in files_search().
-
- 11 Dec, 2019 1 commit
-
-
Signed-off-by:
Ethan Sommer <e5ten.arch@gmail.com> Signed-off-by:
-
