I'm not seeing an approved button. This might be due to me not being a maintainer?
Minor nit. Approved.
[[ "$KERNELVERSION" == 'none' ]] && return 0
[[ "$kernver" != 'none' ]] && install -dm755 "$buildroot/usr/lib/modules/$kernver/kernel"
Was this patch applied? Do we want to ensure there's a newline at the end of the file/before the echo?
Isaac Good (2702df45) at 02 Nov 23:40
Add a new Check to ensure package filename matches the package info...
... and 10 more commits
Isaac Good (9467ff95) at 02 Nov 04:14
Add a new Check to ensure package filename matches the package info...
... and 5 more commits
I'm not understanding what should be checked and where. The add_packages()
workflow has the filename but little to no other information (optional architecture). What would be checked? And where?
I extended this check to check arch, name, version. The filename_parts()
is very handy, though I'm debating if it would be better switched from taking a Path
to taking a str
.
It works fine living where it is. I'm also happy to move it, if you have a more suitable location you can suggest. I'm not familiar with the project layout so I don't know where things ought to live.
Fixed! I'm not sure if using that fixture makes sense as this check doesn't work with "any valid filename" but requires a very specific string.
Reworded in light of other changes.
Isaac Good (f495c6b9) at 22 Oct 15:41
Add a new Check to ensure package filename matches the package info...
... and 9 more commits
Closes #136
Add a new Check to ensure package filename matches the package info name.
docs/repod/changelog.rst: Document the new package name check.
repod/action/check.py: Add a new MatchingFilenameCheck which checks that the package filename matches the package's metadata.
repod/action/task.py: Add a MatchingFilenameCheck when creating a new package.
tests/action/test_check.py: Add tests to ensure the MatchingFilenameCheck works correctly.
Isaac Good (6f54aeff) at 22 Oct 01:16
Add a new Check to ensure package filename matches the package info...
Isaac Good (01e6d366) at 22 Oct 01:15
Add a new Check to ensure package filename matches the package info...
Isaac Good (0c841390) at 22 Oct 00:55
Add a new Check to ensure package filename matches the package info...
... and 1 more commit
Isaac Good (90bacb09) at 18 Oct 23:09
Replaced usage of format_ with schema_version in BuildInfo.
Closes #80 (closed)
Replaced usage of format_ with schema_version in BuildInfo.
repod/files/buildinfo.py: Replace uses of FormatV1, FormatV2 with SchemaVersionV1, SchemaVersionV2. Delete the Format classes.
repod/repo/management/outputpackage.py: Replace uses of FormatV1, FormatV2 with SchemaVersionV1, SchemaVersionV2. Delete the Format classes.
tests/conftest.py: Update buildinfo test data, replacing "format" with "schema_version".
tests/files/test_buildinfo.py: Remove tests which test FormatV1, FormatV2.
Isaac Good (74efa3c3) at 18 Oct 05:37
Replaced usage of format_ with schema_version in BuildInfo.