Merge pull request #252 from grazzolini/arch_announce_password

news: Add the MAILMAN_PASSWORD option and use it for sending authenticated emails

news/views.py

 from django import forms
-from django.core.mail import send_mail
+from django.conf import settings
+from django.core.mail import EmailMessage
 from django.http import HttpResponse
 from django.shortcuts import get_object_or_404, redirect
 from django.template import loader
@@ -43,12 +44,15 @@ def form_valid(self, form):
             ctx = {
                 'news': newsitem,
             }
+            headers = dict()
+            if settings.MAILMAN_PASSWORD:
+                headers['Approved'] = settings.MAILMAN_PASSWORD
             template = loader.get_template('news/news_email_notification.txt')
-            send_mail('[arch-announce] %s' % newsitem.title,
-                      template.render(ctx),
-                      '"Arch Linux: Recent news updates: %s" <arch-announce@archlinux.org>' % newsitem.author.get_full_name(),
-                      ['arch-announce@archlinux.org'],
-                      fail_silently=True)
+            EmailMessage(subject='[arch-announce] %s' % newsitem.title,
+                      body=template.render(ctx),
+                      from_email='"Arch Linux: Recent news updates: %s" <arch-announce@archlinux.org>' % newsitem.author.get_full_name(),
+                      to=['arch-announce@archlinux.org'],
+                      headers=headers).send()
         return super(NewsCreateView, self).form_valid(form)
 
 

settings.py

@@ -178,6 +178,9 @@
 # Make this unique, and don't share it with anybody.
 SECRET_KEY = '00000000000000000000000000000000000000000000000'
 
+# Mailman poster password for announcements
+MAILMAN_PASSWORD = ''
+
 DATABASES = {
     'default': {
         'ENGINE':  'django.db.backends.sqlite3',