Commit be5197a5 authored by Eli Schwartz's avatar Eli Schwartz Committed by Lukas Fleischer
Browse files

prevent running mysql-specific query in sqlite



We usually guard such queries and have both mysql and sqlite branches.
But I have not implemented the sqlite branch. Given sqlite is typically
used for local dev setups, the fact that "users with more than the
configured max simultaneous logins" can avoid getting some logins
annulled is probably not a huge risk.

And this always *used* to fail on sqlite, silently. Now, in php 8, it
raises PDOException, which prevents running the test server

Document this as a FIXME for now, until someone reimplements the query
for sqlite.
Signed-off-by: Eli Schwartz's avatarEli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Lukas Fleischer's avatarLukas Fleischer <lfleischer@archlinux.org>
parent d92dd69a
......@@ -597,7 +597,9 @@ function try_login() {
/* Generate a session ID and store it. */
while (!$logged_in && $num_tries < 5) {
$session_limit = config_get_int('options', 'max_sessions_per_user');
if ($session_limit) {
# FIXME: this does not work for sqlite (JOIN in a DELETE clause)
# hence non-prod instances can have a naughty amount of simultaneous logins
if ($backend == "mysql" && $session_limit) {
/*
* Delete all user sessions except the
* last ($session_limit - 1).
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment