Frédéric Mangano-Tarumi authored Jul 27, 2020 and Lukas Fleischer committed Feb 20, 2021

Error outputs were piped to a temporary buffer that wasn’t read by
anyone, making debugging hard because errors were completely silenced.
By not explicitly redirecting stderr on proc_open, the subprocess
inherits its parent stderr.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Eli Schwartz authored Feb 16, 2021 and Lukas Fleischer committed Feb 20, 2021

Due to missing whitespace at the end of strings during joining, we ended
up with the query fragment

"DelTS IS NULLAND NOT PinnedTS"

which should be

"DelTS IS NULL AND NOT PinnedTS"

So the check for pinned comments > 5 likely always failed.

In php 7, a completely broken query that raises exceptions in the
database engine was silently ignored... in php 8, it raises

Uncaught PDOException: SQLSTATE[HY000]: General error: 1 near "PinnedTS": syntax error in <file>

and aborts the page building. End result: users with permission to pin
comments cannot see any comments, or indeed page content below the first
comment header
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

VCS packages should not be flagged out-of-date when the package version
does not match the most recent commit.

Implements FS#62733.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Notifications are still going to the wrong people. We tried to fix this
in commit b702e5c0

, but only fixed it
for the python callers. There's another caller in the php code, which
needs to use the right order of arguments as well.

Fixes FS#60601
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>

Johannes Löthberg authored Aug 06, 2018 and Lukas Fleischer committed Aug 06, 2018

Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Johannes Löthberg authored Aug 06, 2018 and Lukas Fleischer committed Aug 06, 2018

Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Jelle van der Waa authored Feb 28, 2018 and Lukas Fleischer committed Mar 10, 2018

Signed-off-by: Jelle van der Waa <jelle@vdwaa.nl>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Mark Weiman authored Feb 05, 2018 and Lukas Fleischer committed Feb 24, 2018

Implements FS#53832.
Signed-off-by: Mark Weiman <mark.weiman@markzz.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Instead of converting package comments from plain text to HTML code when
they are displayed, do the conversion when the comment is posted and
store the rendered result in the database. The conversion itself is done
by a Python script which uses Bleach for sanitizing the text.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Instead of unconditionally calling fetch on the return value of query(),
error out early if the value evaluates to false.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Do not trigger a PHP warning if there are no votes to be added or
removed.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

The variable $action is always undefined in pkgbase_delete() which makes
the if-statement always true and triggers a warning whenever a package
base is removed.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Do not overwrite the $uid variable when updating co-maintainers.

Fixes FS#52225.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Mark Weiman authored Nov 09, 2016 and Lukas Fleischer committed Nov 10, 2016

UNIX_TIMESTAMP is not part of the SQL standard. Instead, all usage in
the web interface is changed to use PHP's time() function.
Signed-off-by: Mark Weiman <mark.weiman@markzz.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Remove a leftover var_dump() invocation that was introduced in commit
5fb7a74e

 (Replace categories with keywords, 2015-06-13).
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Add a new option that makes it possible to subscribe to package
ownership changes (adoption/disownment).

Fixes FS#15412.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Mark Weiman authored Feb 16, 2016 and Lukas Fleischer committed Feb 19, 2016

In pkg_comments.php, the $pinned variable is used to determine whether
the template is supposed to print all comments or pinned comments only.
If the $pinned variable is unset, the top 10 comments are printed,
followed by an "All comments" link. If the $pinned variable is set, the
pinned comments are printed and the "All comments" link below the
comment listing is skipped. Thus, we need to make sure that this
variable is always unset at the time we include the template to display
all comments, even if it was empty before.

Fixes FS#48194.
Signed-off-by: Mark Weiman <mark.weiman@markzz.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

As a preparatory step to adding support for package notifications on
events other than comments, rename the database table accordingly.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Marcel Korpel authored Jan 19, 2016 and Lukas Fleischer committed Jan 23, 2016

Only Developers and Trusted Users can undelete comments.
Signed-off-by: Marcel Korpel <marcel.korpel@gmail.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Mark Weiman authored Dec 14, 2015 and Lukas Fleischer committed Dec 15, 2015

Implements: FS#46546
Signed-off-by: Mark Weiman <mark.weiman@markzz.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Instead of modifying EditedTS when a comment is deleted, use a separate
field DelTS. Use this field to determine whether a comment has been
deleted, instead of checking DelUsersID which might be unset when the
corresponding user is deleted.

Fixes FS#47362.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Directly retrieve comments from the database instead of additionally
passing them via stdin.

Fixes FS#46742.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Mark Weiman authored Dec 11, 2015 and Lukas Fleischer committed Dec 12, 2015

Adds capability to pin comments before others.

Implements FS#10863.
Signed-off-by: Mark Weiman <mark.weiman@markzz.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

This code is no longer needed since 9746a654

 (Port notification routines
to Python, 2015-06-27).
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Implements FS#45590.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

This makes the code slightly more efficient and allows for easily
determining the users that were added/removed to the co-maintainer list.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

When a package base is merged into another one, followers of the old
package base usually want to be notified about comments the new package
base as well.

Fixes FS#27687.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Implements FS#42827.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Sometimes, a user accidentally flags a package out-of-date. Allow users
to unflag packages that they flagged themselves, thereby providing a way
to undo these actions.

Implements FS#46145.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Add a new FlaggerUID field to the database and use it to store the user
ID of the account who recently flagged a package out-of-date.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Marcel Korpel authored Aug 17, 2015 and Lukas Fleischer committed Aug 17, 2015

Fixes FS#45870.
Signed-off-by: Marcel Korpel <marcel.korpel@gmail.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Marcel Korpel authored Jul 21, 2015 and Lukas Fleischer committed Aug 08, 2015

For use in the new RPC interface to edit comments, the form shouldn't
always print a header. Create a new template pkg_comment_box.php that
prints form and box, change template pkg_comment_form.php to only
print the form.
Signed-off-by: Marcel Korpel <marcel.korpel@gmail.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Fixes FS#45600.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Marcel Korpel authored Jul 10, 2015 and Lukas Fleischer committed Aug 08, 2015

Signed-off-by: Marcel Korpel <marcel.korpel@gmail.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Marcel Korpel authored Jul 10, 2015 and Lukas Fleischer committed Aug 08, 2015

Create two new actions, do_AddComment and do_EditComment. When editing
or deleting a comment, a timestamp is added.
Signed-off-by: Marcel Korpel <marcel.korpel@gmail.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Use a Python script for sending notification emails. The notification
action and additional parameters are passed via command line arguments.
For comment and package request notifications, the text is passed via
stdin.
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Johannes Löthberg authored Jun 20, 2015 and Lukas Fleischer committed Jun 20, 2015

Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Johannes Löthberg authored Jun 20, 2015 and Lukas Fleischer committed Jun 20, 2015

Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>