- 17 Sep, 2012 1 commit
-
-
canyonknight authored
All DB code currently uses the quickly aging mysql_* functions. These functions are strongly discouraged and may eventually be deprecated. Transition all code to utilize the PDO data access abstraction layer. PDO allows for consistent query code across multiple databases. This could potentially allow for someone to use a database other than MySQL with minimal code changes. All functions and behaviors are reproduced as faithfully as possible with PDO equivalents and some changes in code. Signed-off-by:
canyonknight <canyonknight@gmail.com> Signed-off-by:
Lukas Fleischer <archlinux@cryptocrack.de>
-
- 23 Aug, 2012 7 commits
-
-
canyonknight authored
Signed-off-by:
-
canyonknight authored
Signed-off-by:
-
canyonknight authored
Currently everyone is allowed to unflag a package as out of date. This should be limited to only the appropriate people for a specific package. Fixes FS#27263 Signed-off-by:
-
canyonknight authored
Packages can currently be submitted with variables longer than the maximum allowed by the DB for that specific field. The string will be shortened without informing the user. This can result in unexpected oddities on submitted packages. Print error messages informing the user when the package name, URL, description, license, or version is too long. Also move the resolution of full package version (including epoch) to an earlier point in pkgsubmit.php Signed-off-by:
-
canyonknight authored
Prior to version 1.3.8 of Archive_Tar, long filenames within a tar file would result in the filename being a shortened string of the fullname. This shortening would prevent the upload of any tar file having a filepath longer than 99 characters. Require AUR installations to use an update Archive_Tar version to avoid related issues Fixes FS#30472 Signed-off-by:
-
canyonknight authored
The "Required by" column already handles an empty list appropriately. Move a </div> tag to match that behavior in the "Dependencies" column Signed-off-by:
-
canyonknight authored
Logged out users who navigate to /submit currently reach a page with only an error message. This adds the full navigation bar for users who errantly reach /submit before logging in. Signed-off-by:
-
- 18 Jul, 2012 8 commits
-
-
Lukas Fleischer authored
Link to "/packages/$pkgname/voters/" instead of using "/voters/" and a get parameter to request a specific package by ID. Signed-off-by: -
Lukas Fleischer authored
archweb uses "<div></div>" and "<p></p>" here. Signed-off-by: -
Lukas Fleischer authored
Signed-off-by: -
Lukas Fleischer authored
Use include_once() instead of include(). Otherwise, a fatal error is shown if the virtual path feature is used since "web/lib/aur.inc.php" is already included in the routing front end. Signed-off-by: -
Lukas Fleischer authored
* Add a missing quote to the "alt" attribute. Regression introduced in d8b2eb4b . * Retrieve and store the package name before overwriting the "$row" variable. Signed-off-by:
-
Lukas Fleischer authored
Regression introduced in 2425f963 . Signed-off-by:
-
Lukas Fleischer authored
Make sure that pkg_change_category() works, even if the "N" get parameter is used and "ID" is unset. Note that this is considered to be a hack rather than a proper fix; pkg_change_category() needs a lot of work. Signed-off-by: -
Lukas Fleischer authored
Minor oversight when adding the routing back end in commit eb22bcc7 . Signed-off-by:
-
- 17 Jul, 2012 11 commits
-
-
Lukas Fleischer authored
Return the correct route -- even if a "/" is appended to the URI. Signed-off-by: -
Lukas Fleischer authored
This needs to be available on every page since it is needed for get_uri() and get_pkg_uri() and "web/html/index.php" isn't executed if the virtual path feature is disabled. Reported-by:
-
Lukas Fleischer authored
Fix a notice that appeared if comments were available and the package was requested by name. See 07d3649c for a similar fix for links to the voters page. Signed-off-by:
-
Lukas Fleischer authored
Move the flag/unflag action below the flag date. Signed-off-by: -
Lukas Fleischer authored
Signed-off-by: -
Lukas Fleischer authored
Do not show the actions form if it doesn't contain any elements. This comes into effect if the virtual path feature is enabled and the current user doesn't have TU/developer privileges. Signed-off-by: -
Lukas Fleischer authored
Signed-off-by: -
Lukas Fleischer authored
Note that this currently only works if the virtual path feature is enabled. If you don't use virtual paths, these will still be displayed as buttons below the package details listing. Signed-off-by: -
Lukas Fleischer authored
This allows for using following URLs: * /package/$pkg_name/flag: Flag a package out-of-date * /package/$pkg_name/unflag: Unflag a package * /package/$pkg_name/notify: Enable comment notifications * /package/$pkg_name/unnotify: Disable comment notifications * /package/$pkg_name/vote: Vote for the package * /package/$pkg_name/unvote: Remove vote Note that this code is very hackish and should be refactored once we drop support for legacy URLs. Signed-off-by: -
Lukas Fleischer authored
Signed-off-by: -
Lukas Fleischer authored
When a package is requested by name, the "ID" request parameter might be unset. Use the "ID" field of the query result instead. Signed-off-by:
-
- 15 Jul, 2012 6 commits
-
-
Lukas Fleischer authored
Regression introduced in f3ce74c7 when resolving conflicts. Signed-off-by:
-
Lukas Fleischer authored
Jump to the home page instead of displaying a page that only tells you that you're logged in. Signed-off-by: -
Lukas Fleischer authored
Extend the routing front/back ends to allow for using "/package/$pkgname/" for individual packages. Signed-off-by: -
Lukas Fleischer authored
Use virtual paths in links (e.g. link to "/packages/" instead of "/packages.php" etc.) if the virtual path feature is enabled. Signed-off-by: -
Lukas Fleischer authored
This is needed for our new URI scheme, since we will use virtual directories, such as "/packages/" instead of "/packages.php" etc. Having relative URIs results in incorrect paths, such as "/packages/css/aur.css" (instead of "/css/aur.css"). Signed-off-by: -
Lukas Fleischer authored
This adds a URL mapping library that can be used to implement virtual paths. Also, "web/html/index.php" is moved to "web/html/home.php" and "web/html/index.php" becomes a routing front end that maps virtual paths to corresponding files. To enable the virtual path feature, all requests need to be redirected to the "index.php" routing script. If you use lighttpd, following rewrite rule can be used: url.rewrite = ( "^(.*)$" => "/index.php/$1" ) A similar rule can be used for Apache (using mod_rewrite). Note that the current routing front end only works if PATH_INFO is provided. Signed-off-by:
-
- 14 Jul, 2012 4 commits
-
-
Lukas Fleischer authored
Conflicts: web/html/account.php web/html/addvote.php web/html/pkgsubmit.php web/lib/acctfuncs.inc.php web/template/actions_form.php web/template/pkg_comment_form.php web/template/pkg_comments.php web/template/pkg_details.php web/template/pkg_search_results.php web/template/tu_details.php
-
canyonknight authored
A foreach() being run without checking to see if the uploaded PKGBUILD had any sources now no longer causes an undefined index notice when there are no sources. Signed-off-by:
-
canyonknight authored
Signed-off-by:
-
canyonknight authored
Fixes broken account suspension system. Signed-off-by:
-
- 11 Jul, 2012 2 commits
-
-
canyonknight authored
Signed-off-by:
-
canyonknight authored
Signed-off-by:
-
- 09 Jul, 2012 1 commit
-
-
Lukas Fleischer authored
The corresponding closing "</div>" tag is only printed if the if-branch is taken, which results in broken HTML code if the if-branch is skipped. Move the "<div>" tag so that either both or none of the tags are included in the generated HTML code. Signed-off-by:
-
