1. 20 Feb, 2021 2 commits
    • Frédéric Mangano-Tarumi's avatar
      Stop redirecting stderr with proc_open · 9290eee1
      Frédéric Mangano-Tarumi authored and Lukas Fleischer's avatar Lukas Fleischer committed
      
      
      Error outputs were piped to a temporary buffer that wasn’t read by
      anyone, making debugging hard because errors were completely silenced.
      By not explicitly redirecting stderr on proc_open, the subprocess
      inherits its parent stderr.
      Signed-off-by: Lukas Fleischer's avatarLukas Fleischer <lfleischer@archlinux.org>
      9290eee1
    • Eli Schwartz's avatar
      fix broken SQL query that always failed · d92dd69a
      Eli Schwartz authored and Lukas Fleischer's avatar Lukas Fleischer committed
      
      
      Due to missing whitespace at the end of strings during joining, we ended
      up with the query fragment
      
      "DelTS IS NULLAND NOT PinnedTS"
      
      which should be
      
      "DelTS IS NULL AND NOT PinnedTS"
      
      So the check for pinned comments > 5 likely always failed.
      
      In php 7, a completely broken query that raises exceptions in the
      database engine was silently ignored... in php 8, it raises
      
      Uncaught PDOException: SQLSTATE[HY000]: General error: 1 near "PinnedTS": syntax error in <file>
      
      and aborts the page building. End result: users with permission to pin
      comments cannot see any comments, or indeed page content below the first
      comment header
      Signed-off-by: Eli Schwartz's avatarEli Schwartz <eschwartz@archlinux.org>
      Signed-off-by: Lukas Fleischer's avatarLukas Fleischer <lfleischer@archlinux.org>
      d92dd69a
  2. 25 May, 2019 1 commit
  3. 26 Oct, 2018 1 commit
  4. 06 Aug, 2018 2 commits
  5. 10 Mar, 2018 1 commit
  6. 24 Feb, 2018 1 commit
  7. 24 Apr, 2017 1 commit
  8. 23 Apr, 2017 1 commit
  9. 18 Apr, 2017 1 commit
  10. 27 Feb, 2017 2 commits
  11. 24 Feb, 2017 1 commit
  12. 10 Nov, 2016 1 commit
  13. 02 Jun, 2016 1 commit
  14. 21 Feb, 2016 1 commit
  15. 19 Feb, 2016 1 commit
    • Mark Weiman's avatar
      Unset $pinned unconditionally when displaying comments · c23914fc
      Mark Weiman authored and Lukas Fleischer's avatar Lukas Fleischer committed
      
      
      In pkg_comments.php, the $pinned variable is used to determine whether
      the template is supposed to print all comments or pinned comments only.
      If the $pinned variable is unset, the top 10 comments are printed,
      followed by an "All comments" link. If the $pinned variable is set, the
      pinned comments are printed and the "All comments" link below the
      comment listing is skipped. Thus, we need to make sure that this
      variable is always unset at the time we include the template to display
      all comments, even if it was empty before.
      
      Fixes FS#48194.
      Signed-off-by: default avatarMark Weiman <mark.weiman@markzz.com>
      Signed-off-by: Lukas Fleischer's avatarLukas Fleischer <lfleischer@archlinux.org>
      c23914fc
  16. 07 Feb, 2016 1 commit
  17. 23 Jan, 2016 1 commit
  18. 15 Dec, 2015 1 commit
  19. 13 Dec, 2015 2 commits
  20. 12 Dec, 2015 1 commit
  21. 12 Nov, 2015 1 commit
  22. 21 Oct, 2015 1 commit
  23. 17 Oct, 2015 2 commits
  24. 16 Sep, 2015 1 commit
  25. 11 Sep, 2015 1 commit
  26. 30 Aug, 2015 2 commits
  27. 17 Aug, 2015 1 commit
  28. 08 Aug, 2015 5 commits
  29. 20 Jun, 2015 2 commits