1. 20 Feb, 2021 2 commits
    • Eli Schwartz's avatar
      prevent running mysql-specific query in sqlite · be5197a5
      Eli Schwartz authored and Lukas Fleischer's avatar Lukas Fleischer committed
      
      
      We usually guard such queries and have both mysql and sqlite branches.
      But I have not implemented the sqlite branch. Given sqlite is typically
      used for local dev setups, the fact that "users with more than the
      configured max simultaneous logins" can avoid getting some logins
      annulled is probably not a huge risk.
      
      And this always *used* to fail on sqlite, silently. Now, in php 8, it
      raises PDOException, which prevents running the test server
      
      Document this as a FIXME for now, until someone reimplements the query
      for sqlite.
      Signed-off-by: Eli Schwartz's avatarEli Schwartz <eschwartz@archlinux.org>
      Signed-off-by: Lukas Fleischer's avatarLukas Fleischer <lfleischer@archlinux.org>
      be5197a5
    • Eli Schwartz's avatar
      fix broken SQL query that always failed · d92dd69a
      Eli Schwartz authored and Lukas Fleischer's avatar Lukas Fleischer committed
      
      
      Due to missing whitespace at the end of strings during joining, we ended
      up with the query fragment
      
      "DelTS IS NULLAND NOT PinnedTS"
      
      which should be
      
      "DelTS IS NULL AND NOT PinnedTS"
      
      So the check for pinned comments > 5 likely always failed.
      
      In php 7, a completely broken query that raises exceptions in the
      database engine was silently ignored... in php 8, it raises
      
      Uncaught PDOException: SQLSTATE[HY000]: General error: 1 near "PinnedTS": syntax error in <file>
      
      and aborts the page building. End result: users with permission to pin
      comments cannot see any comments, or indeed page content below the first
      comment header
      Signed-off-by: Eli Schwartz's avatarEli Schwartz <eschwartz@archlinux.org>
      Signed-off-by: Lukas Fleischer's avatarLukas Fleischer <lfleischer@archlinux.org>
      d92dd69a
  2. 14 Oct, 2020 1 commit
  3. 05 Sep, 2020 1 commit
  4. 27 Aug, 2020 1 commit
  5. 26 Aug, 2020 1 commit
  6. 05 Apr, 2020 2 commits
  7. 27 Mar, 2020 3 commits
  8. 22 Mar, 2020 1 commit
  9. 29 Feb, 2020 3 commits
  10. 27 Feb, 2020 6 commits
  11. 26 Feb, 2020 3 commits
  12. 13 Feb, 2020 2 commits
  13. 11 Feb, 2020 4 commits
  14. 10 Feb, 2020 1 commit
  15. 02 Feb, 2020 9 commits