- 29 Mar, 2021 1 commit
-
-
The account deletion code tries to remove user from PackageNotifications using the wrong column UsersID to identify the user by id. In the PackagePackageNotifications table the foreign key is called UserID. In the future ideally this would be unified into UserID for all tables. Closes: #12 Signed-off-by:Lukas Fleischer <lfleischer@archlinux.org>
-
- 20 Feb, 2021 39 commits
-
-
This docker file downloads deps, sets up some things beforehand and finishes with running our entire collection of tests. Signed-off-by:
Kevin Morris <kevr@0cost.org>
Signed-off-by: -
Additionally, we now ask for two more favors from contributors: 1. All source modified or added within a patchset **must** maintain equivalent or increased coverage by providing tests that use the functionality. 2. Please keep your source within an 80 column width. PS: Sneak a few test Makefile and gitlab fixes. Signed-off-by:Kevin Morris <kevr@0cost.org> -
Signed-off-by:Kevin Morris <kevr@0cost.org> -
We had no coverage over aurweb.scripts.popupdate. This test covers all of its functionality. Signed-off-by:Kevin Morris <kevr@0cost.org> -
This helps gain coverage over aurweb.exceptions regardless of their actual use in the testing base. Signed-off-by:Kevin Morris <kevr@0cost.org> -
Important note: Python tests will repeatedly clear out tables that they test against; for this reason, one should always run the shell tests first. The __init__.py file is necessary for coverage to collect data from the tests being run. At this point in FastAPI development, I'd like to encourage a few things going forward: 1. Any time you contribute to the FastAPI codebase, you **must** maintain equal or increased coverage on the overall source. Developers are highly appreciated for adding tests in your specific domain of addition or modification that may be missing coverage. Our goal is 100% coverage, and all newly added files **must** have 100% coverage through tests. 2. All source should be formatted with the autopep8 tool and kept within an 80 column width, with the exception of HTML templates. Signed-off-by:Kevin Morris <kevr@0cost.org> -
Now, .coveragerc enforces a minimum overall 82% coverage, as is the current standing. Providing less than 100% coverage for added code should reduce the overall coverage and eventually reach 81% or below, causing coverage report to fail on execution. Developers should increase the failure minimum as they increase coverage across the uncovered code. Signed-off-by:Kevin Morris <kevr@0cost.org> -
Signed-off-by:
Kevin Morris <kevr@0cost.org>
Signed-off-by: -
jsdelivr is another free CDN service for open source projects. The main motivation for this change is that it is the only one that works fairly well across the globe. The Google CDN service is known to be hardly accessible in mainland China, unfortunately. Signed-off-by: -
https://www.transifex.comLukas Fleischer authored
Fixes GitLab issue #3 . Signed-off-by:
-
Lukas Fleischer authored
Signed-off-by: -
I think after 10-15 years we might want to adjust those values. With a 30min cache and 20 items per creation I would bet some new AUR packages might be swept under the carpet. Signed-off-by: -
-
-
-
-
When the keyword parameter is empty, the AND clause has to be omitted, otherwise we get an SQL syntax error: ... WHERE PackageBases.PackagerUID IS NOT NULL AND () ... This got broken in commit 9e30013a Author: Kevin Morris <kevr.gtalk@gmail.com> Date: Sun Jul 5 18:19:06 2020 -0700 Support conjunctive keyword search in RPC interface Signed-off-by:
-
Signed-off-by: -
Signed-off-by: -
Of course the default exit code is 0... Signed-off-by: -
Signed-off-by: -
Signed-off-by:
Filipe Laíns <lains@archlinux.org>
Signed-off-by: -
Signed-off-by:
Filipe Laíns <lains@archlinux.org>
Signed-off-by: -
Signed-off-by:
Filipe Laíns <lains@archlinux.org>
Signed-off-by: -
This allows using a relative path for the config. PHP didn't play well with it. Signed-off-by:
Filipe Laíns <lains@archlinux.org>
Signed-off-by: -
Introduce a `redirect` query argument to SSO login endpoints so that users are redirected to the page they were originally on when they clicked the Login link. Signed-off-by: -
This feature was originally introduced by f961ffd9 as a fix for FS#12898 <https://bugs.archlinux.org/task/12898 >. As of today, it is broken because of the `q.SessionID IS NULL` condition in the WHERE clause, which can’t be true because SessionID is not nullable. As a consequence, the session limit was not applied. The fact the absence of the session limit hasn’t caused any issue so far, and hadn’t even been noticed, suggests the feature is unneeded. Signed-off-by:
-
Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
Error outputs were piped to a temporary buffer that wasn’t read by anyone, making debugging hard because errors were completely silenced. By not explicitly redirecting stderr on proc_open, the subprocess inherits its parent stderr. Signed-off-by: -
Only ttys have a terminal size. If we can’t obtain it, we’ll just use 80 as a sane default. Signed-off-by: -
The existing notify.py script was grabbing entries regardless of user suspension. This has been modified to only send notifications to unsuspended users. This change was written as a solution to https://bugs.archlinux.org/task/65554 . Signed-off-by:
Kevin Morris <kevr.gtalk@gmail.com> Signed-off-by:
-
Newly supported API Version 6 modifies `type=search` for _by_ type `name-desc`: it now behaves the same as `name-desc` search through the https://aur.archlinux.org/packages/ search page. Search for packages containing the literal keyword `blah blah` AND `haha`: https://aur.archlinux.org/rpc/?v=6&type=search&arg="blah blah"%20haha Search for packages containing the literal keyword `abc 123`: https://aur.archlinux.org/rpc/?v=6&type=search&arg="abc 123" The following example searches for packages that contain `blah` AND `abc`: https://aur.archlinux.org/rpc/?v=6&type=search&arg=blah%20abc The legacy method still searches for packages that contain `blah abc`: https://aur.archlinux.org/rpc/?v=5&type=search&arg=blah%20abc https://aur.archlinux.org/rpc/?v=5&type=search&arg=blah%20abc API Version 6 is currently only considered during a `search` of `name-desc`. Note: This change was written as a solution to https://bugs.archlinux.org/task/49133 . PS: + Some spacing issues fixed in comments. Signed-off-by:
-
Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
As far as I can see, Keycloak ignores it entirely. I can login in as SSO user A, then disconnect from the SSO directly and reconnect as user B, but when I disconnect user A from AUR, Keycloak disconnects B even though AUR passed it an ID token for A. Signed-off-by: -
Signed-off-by:
-
