Skip to content
GitLab
This project is mirrored from https://:*****@gitlab.archlinux.org/archlinux/aurweb.git. Pull mirroring updated .
  1. 27 Apr, 2011 2 commits
  3. 24 Apr, 2011 2 commits
  5. 19 Apr, 2011 6 commits
  7. 16 Apr, 2011 4 commits
    • tuxce's avatar
      rpc: unify methods return (fixes FS#17597) · c6d84b3a
      tuxce authored 
      

Include maintainer in info and search method.

Lukas: Adjustments for "multiinfo" queries.

Signed-off-by: default avatarLukas Fleischer <archlinux@cryptocrack.de>
      c6d84b3a
    • Dan McGee's avatar
      rpc: introduce multiinfo query (fixes FS#17583) · 0488e859
      Dan McGee authored 
      The majority of "real world" info requests [1] come in hefty batches. We
would be better served to handle these in one request rather than
multiple by allowing AUR clients to send multiple arguments.

This enables things like this to work:
    http://aur.test/rpc.php?type=multiinfo&arg[]=cups-xerox&arg[]=cups-mc2430dl&arg[]=10673



Note to RPC users: unfortunately due to the asinine design of PHP, you
unfortunately have to use the 'arg[]' syntax if you want more than one
query argument, or you will only get the package satisfying the last arg
you pass.

[1] Rough data from April 11, 2011, with a total hit count of 1,109,163:
     12 /login.php
     13 /rpc.php?type=sarch
     15 /rpc.php?type=msearch
     16 /pingserver.php
     16 /rpc.php
     22 /logout.php
    163 /passreset.php
    335 /account.php
    530 /pkgsubmit.php
    916 /rss2.php
   3838 /index.php
   6752 /rss.php
   9699 /
  42478 /rpc.php?type=search
 184737 /packages.php
 681725 /rpc.php?type=info

That means a whopping 61.5% of our requests were for info over the RPC
interface; package pages are a distant second at only 16.7%.

Lukas: Introduce "multiinfo" query instead of extending "info" (for the
sake of backward compatibility).

Signed-off-by: default avatarDan McGee <dan@archlinux.org>
Signed-off-by: default avatarLukas Fleischer <archlinux@cryptocrack.de>
      0488e859
    • Dan McGee's avatar
      rpc.php: be a bit more consistent in query building · a3ad0601
      Dan McGee authored 
      

Do the implode as the same but separate step each time, and remove
indentation where no other query has it.

Signed-off-by: default avatarDan McGee <dan@archlinux.org>
Signed-off-by: default avatarLukas Fleischer <archlinux@cryptocrack.de>
      a3ad0601
    • Dan McGee's avatar
      rpc.php overhaul · aa206b34
      Dan McGee authored 
      * Mark things static in the class rather than use a constructor every
  single invocation of the service.
* Don't call mysql_real_escape_string() before we even have a database
  connection, and don't do work in the database if we don't need to.
* Formatting consistency fixups in a few places.
* Add new process_query() helper function; use this instead of
  copy-pasted code in all of the RPC method calls.
* Remove the escaping code meant to fix FS#15526, introduced in commit
  4d1eb4dd

. It broke more than it solved, only fixed the output in
  one of three RPC calls (and who knows what the web interface then also
  does), and proper encoding should be done at the database level rather
  than up here.

Lukas: Add special case for "info" queries to process_query() (return a
single result instead of an array of results here).

Signed-off-by: default avatarDan McGee <dan@archlinux.org>
Signed-off-by: default avatarLukas Fleischer <archlinux@cryptocrack.de>
      aa206b34
  9. 13 Apr, 2011 7 commits
  11. 12 Apr, 2011 5 commits
  13. 11 Apr, 2011 2 commits
  15. 10 Apr, 2011 12 commits