- 20 Feb, 2015 2 commits
-
-
Allan McRae authored
Signed-off-by:Allan McRae <allan@archlinux.org>
-
Allan McRae authored
-
- 14 Feb, 2015 3 commits
-
-
Allan McRae authored
Signed-off-by: -
Allan McRae authored
0002-valgrind.supp-remove-library-version-from-suppressio.patch
-
There was some manual check to know if the local repository was really a clone of the one specified in PKGBUILD. This check has been removed because it is buggy and not necessary. It is buggy because this check needs to be semantic, not a simple string comparison. For example, I was blocked from building a PKGBUILD because Bazaar was returning two different strings for the same location (for HTTP one was url-encoded while the other was not, and for local paths one was absolute while the other was relative). While this may be a bug in Bazaar, the check is unreliable since the comparison is not semantic (http://foo.com/%2Bplus and http://foo.com/+plus obviously refer to the same location for example). Specially, it is useless because the intention is updating the existing local clone. However, if the local clone is not a real clone of the repository specified in PKGBUILD (which was what this buggy check tried to tell), next step which is a pull operation will fail anyway. This is because bzr pull does not perform merges, it just makes one branch into a mirror of another. There was a reason provided when this manual check was added for Git, but no reason provided for copying such check when Bazaar support was added, see commits below. In fact, Mercurial lacks such manual check. * c926c39b * 3b02f80d Fixes FS#43448. Signed-off-by:
-
- 12 Feb, 2015 4 commits
-
-
Allan McRae authored
There was a lot of confusion regarding these warnings, particularly for packages that create users post_install and then chown the directories. Signed-off-by: -
Signed-off-by:
Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by:
-
Allan McRae authored
glibc installs the library /usr/lib/ld-?.??.so with its version. Wildcard this so the suppresses the warning for all glibc versions. Signed-off-by: -
LIBCURL was never set in the Makefile so XferCommand was always being set in the test file. This removes the only substitution in our test files which will prevent the TESTS file from being rebuilt every time configure is run. Signed-off-by:
-
- 01 Feb, 2015 6 commits
-
-
Allan McRae authored
Commit 9e5e86aa was supposed to fix this. Instead I picked another [[ -f ]] statement in the same region and added the hardlink test to it instead, thus not fixing the bug. Signed-off-by:
-
If the call to alpm_logaction failed it would overwrite pm_errno, leading to error messages unrelated to the actual reason the transaction failed. Signed-off-by:
-
Allan McRae authored
Signed-off-by: -
This fixes the issue where if the user explicitly set the name of the cloned source to eg. foo.git, the directory name in $SRCDEST would be foo.git as expected, but the clone in $srcdir would be stripped of the .git suffix. Signed-off-by:
Lukáš Jirkovský <l.jirkovsky@gmail.com> Signed-off-by:
-
Signed-off-by:
Jeffrey Tolar <tolar.jeffrey@gmail.com> Signed-off-by:
-
Signed-off-by:
-
- 21 Jan, 2015 2 commits
-
-
It was allocating the required size rather than the calculated new size, resulting in pathological incremental reallocations. Signed-off-by:
Daniel Micay <danielmicay@gmail.com> Signed-off-by:
-
The files_size variable contains the current capacity (in bytes) and should not be used to calculate the next length increment. It only works because _alpm_greedy_grow currently results in incremental growth. Signed-off-by:
-
- 12 Jan, 2015 1 commit
-
-
Allan McRae authored
If an already used array is passed array_build, some entries from the old array could be carried over if the old array was longer than the new one. Clear the destination array before adding elements to it to prevent this issue. Fixes: https://bugs.archlinux.org/task/43387 Signed-off-by:
-
- 11 Jan, 2015 4 commits
-
-
Fixes https://bugs.archlinux.org/task/43286 Signed-off-by:
Dario Giovannetti <dariogiova@gmail.com>
Signed-off-by: -
acc639ad removed this, but shouldn't have. Signed-off-by:
-
I suspect this is just wrong -- you never need to quote the replacement side of a PE. In bash 4.3, this is essentially a no-op, but because of a bug in bash 4.2, we get embedded quotes as a result of this replacement. The relevant changelog item in bash is: Fixed a bug that caused single quotes that resulted from $'...' quoting in the replacement portion of a double-quoted ${word/pat/rep} expansion to be treated as quote characters. But this doesn't apply to us. Let's just drop the excessive quoting... Signed-off-by: -
Allan McRae authored
When a shared library uses an absolute symlink for its its .so file, the check if the shared version of a static library exists fails. Test for the presence of a broken symlink too. Signed-off-by:
-
- 02 Jan, 2015 4 commits
-
-
Signed-off-by:
Jason St. John <jstjohn@purdue.edu> Signed-off-by:
-
This bombs out when "$trusted" expands to the empty string. We're better off passing the var by name and letting bash default to "0" when the var is empty Fixes: https://bugs.archlinux.org/task/43269 Signed-off-by:
-
This could have been easy with something like chown's --reference flag, but this is GNU specific. Instead, just truncate and rewrite the file. Our exit trap cleans up after us. Fixes: https://bugs.archlinux.org/task/43272 Signed-off-by:
-
Allan McRae authored
Signed-off-by:
-
- 28 Dec, 2014 1 commit
-
-
Allan McRae authored
Do not merge the architecture specific fields when creating a .SRCINFO file. Signed-off-by:
-
- 27 Dec, 2014 2 commits
-
-
Allan McRae authored
Signed-off-by: -
We fixed this up to check architecture specific sources in ec679e09 , but fudged the array name in the in_array call. Signed-off-by:
-
- 24 Dec, 2014 5 commits
-
-
Previously, we used a single boolean value to determine correlation of sources to checksums. Since the introduction of arch-specific sources, this is no longer sufficient, as we must ensure that we have checksums for (potentially) multiple source arrays. This change inlines the logic of have_sources to build an associative array of source array names, unsetting them as we discover their checksums. The error condition then becomes a non-empty correlation array. Fixes: https://bugs.archlinux.org/task/43192 Signed-off-by:
-
Following commit 086bbc5b (Use O_CLOEXEC as much as possible when opening files), the log file would be created by pacman with blank permissions. Signed-off-by:
-
This prevents the database from becoming inaccessible for non-root users when the script was executed with a umask of 027. Signed-off-by:
Peter Wu <peter@lekensteyn.nl> Signed-off-by:
-
Allan McRae authored
We validated all sources when making a source package, whether or not they are included in the tarball. Signed-off-by: -
Allan McRae authored
People have mentioned that the silent upgrade to DB version 9 when no adjustments are needed for directory symlinks is confusion. Always print the upgrading message. Signed-off-by:
-
- 22 Dec, 2014 3 commits
-
-
I'm pretty sure this is some kind of left over stuff that was supposed to print the filename, linenumber and line content. This is already done so just remove it. Signed-off-by:
Florian Pritz <bluewind@xinu.at>
Signed-off-by: -
Allan McRae authored
Signed-off-by: -
Allan McRae authored
Signed-off-by:
-
- 21 Dec, 2014 2 commits
-
-
Signed-off-by: -
Signed-off-by:
-
- 19 Dec, 2014 1 commit
-
-
Re-add some paranoia which was inadvertently lost with 768b65e9 . In case 'makepkg -g' fails to generate new sums (e.g. when a remote resource cannot be fetched), or awk fails to write the new file (i have no idea when this would happen), bail out with an error. Signed-off-by:
-
