Skip to content
GitLab
  1. 15 Dec, 2019 1 commit
  3. 20 Nov, 2019 2 commits
  5. 23 Jun, 2019 5 commits
    • Eli Schwartz's avatar
      remove pointless mkdir -p in parsepkgbuild · 97e816eb
      Eli Schwartz authored and Kyle Keen's avatar Kyle Keen committed 
      As far as I can tell, this was never used.

In commit 9b56647a

 the parsepkgbuild
script was switched from defining a PATH as a directory in /tmp, to
actually passing in a PATH=/dummy to `env -i`... which makes sense as
the defined PATH did not used to be used. However, even before that,
it's not safe to use mkdir -p in order to define a restricted shell
without access to the PATH, as it's not guaranteed to be owned by the
creator.

In any event, the time for mkdir -p is long past.

Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
Signed-off-by: Kyle Keen's avatarKyle Keen <keenerd@gmail.com>
      97e816eb
    • Eli Schwartz's avatar
      add support for new checksum algorithm in pacman-git · 76ab7b6c
      Eli Schwartz authored and Kyle Keen's avatar Kyle Keen committed 
      It is now possible to use b2sums to verify file integrity. See
https://git.archlinux.org/pacman.git/commit/?id=e03752e6adc86cbb4cb4f52a38f6e3e98cbe9dd5



Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
Signed-off-by: Kyle Keen's avatarKyle Keen <keenerd@gmail.com>
      76ab7b6c
    • Eli Schwartz's avatar
      parsepkgbuild: reduce a lot of boilerplate by being more templated · e8b0e405
      Eli Schwartz authored and Kyle Keen's avatar Kyle Keen committed 
      

When listing out the contents of a variable, use loops and references
to the variables in order to reduce code and make it easier to extend.

In the future, a new metadata type can be added simply by appending to
meta_keys=()

Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
Signed-off-by: Kyle Keen's avatarKyle Keen <keenerd@gmail.com>
      e8b0e405
    • Eli Schwartz's avatar
      Add rule to report on unneeded dependencies from hooks · 73cf4a97
      Eli Schwartz authored and Kyle Keen's avatar Kyle Keen committed 
      

Just as it is unnecessary to run certain commands in a post_upgrade
script, if a hook already runs it, so too is it usually unnecessary to
depend on the package that installs the hook.

Sometimes these dependencies are left in even when the install script is
removed, because people lack understanding in the true subtleties of
hooks and the commands they run -- but the commands do not depend on the
list of files which trigger them in order to function, and are fully
operative when installed later. In fact, they will already be required
by the software that uses the results.

e.g. desktop-file-utils and shared-mime-info provide hooks to compile
the mime and desktop file databases, but upon first installing the hook,
a full database will already be compiled. The hook does not need to be
triggered by the filepath, and thus does not need to be a dependency of
every package that provides a desktop or mime file. Instead, desktop
environments which need a mime/desktop file database will depend on the
package and thereby ensure the database exists when needed.

Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
Signed-off-by: Kyle Keen's avatarKyle Keen <keenerd@gmail.com>
      73cf4a97
    • Eli Schwartz's avatar
      Remove no longer useful warnings that have missing keys · ec3c1113
      Eli Schwartz authored and Kyle Keen's avatar Kyle Keen committed 
      

Arch Linux now has pacman hooks that provide automatic handling for
update-{desktop,mime}-database without each package requiring a hard
dependency and a post_upgrade hook. This means it is no longer correct
to depend on the packages or provide an install script. Instead, remove
this entirely. Fixes FS#56898

Signed-off-by: Eli Schwartz <eschwartz at archlinux.org>
Signed-off-by: Kyle Keen's avatarKyle Keen <keenerd@gmail.com>
      ec3c1113
  7. 03 Feb, 2019 1 commit
    • Erich Eckner's avatar
      recognize arch-specific variables even if packages is for only one architecture · 4a4a9d30
      Erich Eckner authored and Kyle Keen's avatar Kyle Keen committed 
      

Architecture-specific variables should be useable as soon as a package
is not built for 'any' architecture. With the deprecation of i686, this
becomes relevant, as many packages are now only built for x86_64.
However, the source (and checksums) may be _not_ architecture-agnostic,
e.g. should _not_ be listed as source= but source_x86_64=.

This patch silences the extra-var-begins-without-underscore message
which is currently emitted in that case.

Signed-off-by: Erich Eckner <arch at eckner.net>
Signed-off-by: Kyle Keen's avatarKyle Keen <keenerd@gmail.com>
      4a4a9d30
  9. 02 Feb, 2019 1 commit
    • Michael Straube's avatar
      makedepends: Make VCS matching more robust · 68c50283
      Michael Straube authored and Kyle Keen's avatar Kyle Keen committed 
      

If a VCS source is renamed using the "::" syntax the makedepends are not
detected. If there are files starting with <name of VCS binary> in the source
array false positives are produced. See the gitlab package for example. Make
the matching more robust to avoid such issues.

Signed-off-by: Michael Straube <michael.straube at posteo.de>
Signed-off-by: Kyle Keen's avatarKyle Keen <keenerd@gmail.com>
      68c50283
  11. 30 Nov, 2018 7 commits
  13. 23 Sep, 2018 2 commits
  15. 07 Jul, 2018 5 commits
  17. 23 Feb, 2018 2 commits
  19. 22 Feb, 2018 2 commits
  21. 07 Jul, 2017 1 commit
  23. 22 Mar, 2017 2 commits
  25. 19 Mar, 2017 2 commits
  27. 13 Mar, 2017 2 commits
  29. 10 Mar, 2017 2 commits
  31. 04 Mar, 2017 1 commit
  33. 11 Dec, 2016 1 commit
  35. 10 Dec, 2016 1 commit