GitLab

Addresses https://lists.archlinux.org/pipermail/pacman-contrib/2021-August/000382.html

Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Thiago Perrotta authored Jul 31, 2021 and Daniel M. Capella committed Aug 02, 2021

`pacman -Fy` is a modern replacement for `pkgfile`[1].

This service/timer makes `pacman -Fy` have feature parity with
`pkgfile`.

The unit files were based on both pkgfile and paccache, for consistency
with the existing ecosystem.

Context: https://bbs.archlinux.org/viewtopic.php?pid=1981076

[1]: https://wiki.archlinux.org/title/Pacman#Search_for_a_package_that_contains_a_specific_file

Signed-off-by: Thiago Perrotta <tbperrotta@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Denton Liu authored Apr 01, 2021 and Daniel M. Capella committed Jul 27, 2021

In 19ab4fac (pacdiff: Add option to use sudo/sudoedit to manage files,
2021-03-27), pacdiff was taught to accept -s to run various commands
with $SUDO. This introduced many instances of $SUDO in merge_file()
where most of them are unnecessary.

In particular, it is not necessary to $SUDO to write the temporary files
as /tmp should be writable by all[0][1].

Also, the usage of sudoedit when comparing the original file with the
merge result is unnecessary. This is because root permissions are not
really required since users should not write to the original file
anyway. The merged file will be used to overwrite the original file at
the end of the function anyway.

Remove these unnecessary usages of $SUDO.

[0]: https://unix.stackexchange.com/a/71625
[1]: https://serverfault.com/a/427290

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Frederik “Freso” S. Olesen authored Jul 09, 2021 and Daniel M. Capella committed Jul 27, 2021

The unit will be run in the background and is not essential for systems
to operate, so giving it the lowest priority will help make it less
disruptive on its system.
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Frederik “Freso” S. Olesen authored Jul 09, 2021 and Daniel M. Capella committed Jul 27, 2021

Adds a number of sandboxing and other hardening options to the
paccache.service file.
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Eli Schwartz authored May 21, 2021 and Daniel M. Capella committed Jul 27, 2021

In the event there are no sources, there won't be sums either. awk won't
find any to remove and replace inline, so it tries to print "" at the
end of the file, and merely adds superfluous newlines.

Abort early instead, since updpkgsums cannot be expected to process such
a file.
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Eli Schwartz via pacman-contrib authored May 21, 2021 and Daniel M. Capella committed May 21, 2021

In "add front-end provided context to callbacks", libalpm gained a new
argument to callbacks which we don't use and is only needed by some
frontends wishing to do stuff with the callback state. NULL it and move
on with life, just like pacman itself did.
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Denton Liu via pacman-contrib authored Mar 29, 2021 and Daniel M. Capella committed Mar 30, 2021

In 19ab4fac

 (pacdiff: Add option to use sudo/sudoedit to manage files,
2021-03-27), the --sudo option was introduced. However, a corresponding
entry was not included in the man page. Document it.

Also, align the usage text in the program with its friends above.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Denton Liu via pacman-contrib authored Mar 29, 2021 and Daniel M. Capella committed Mar 30, 2021

In 94b2a194 (pacdiff: Learn the (M)erge mode, 2021-03-04), 348a2969
(pacdiff: Reduce repetition in input loop, 2021-03-04), and b675c927


(pacdiff: Implement die(), 2021-03-04), the patches were erroneously
applied with incorrect authorship information. Fix this with a new
.mailmap entry.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Denton Liu via pacman-contrib authored Mar 29, 2021 and Daniel M. Capella committed Mar 30, 2021

In 19ab4fac

 (pacdiff: Add option to use sudo/sudoedit to manage files,
2021-03-27), the patch was erroneously applied with incorrect authorship
information. Fix this with a new .mailmap entry.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Daniel Parks via pacman-contrib authored Mar 27, 2021 and Daniel M. Capella committed Mar 28, 2021

This allows the user to run their diff program as their own user instead
of root. The advantage of this approach is that they can use their own
configuration for the editor or even use a GUI merge program such as
meld.
Signed-off-by: Daniel Parks <danielrparks@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Denton Liu via pacman-contrib authored Mar 04, 2021 and Daniel M. Capella committed Mar 25, 2021

Currently, pacdiff only allows users to diff between the current file
and the new file. However, the merging of files could be automated by
the use of some 3-way merge utility.

Teach pacdiff the (M)erge mode which performs a 3-way merge using a
given $MERGEPROG (`diff3 -m` by default). The base file is taken from
from the second-newest package in the cache.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Denton Liu via pacman-contrib authored Mar 04, 2021 and Daniel M. Capella committed Mar 25, 2021

The input loop repeats the `ask` code twice. In a future commit, we will
be introducing another instance of the `ask` code. This makes it
possible to mistakenly make the code to get out of sync.

Refactor the loop so that the `ask` code happens once at the top of the
loop. This introduces one functional change in the "Invalid answer" case
but it also makes it more consistent with the remaining cases.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Denton Liu via pacman-contrib authored Mar 04, 2021 and Daniel M. Capella committed Mar 25, 2021

In a future commit, we will be making more use of this function. For
now, implement it and use it in the one place where it's applicable.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Denton Liu authored Dec 25, 2020 and Daniel M. Capella committed Feb 07, 2021

The way that the awk script used for fetching files from the pacdb is
indented is very misleading. It appears as if the `print $1` is part of
the if.

Unindent the `print $1` and the following closing brace so that it's
obvious that they are part of the while.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Denton Liu authored Dec 25, 2020 and Daniel M. Capella committed Feb 07, 2021

There is a missing colon so, as a result, the following line is rendered
incorrectly as

	-v, --version: Display the version.

instead of

	-v, --version
	    Display the version.

Add the missing colon so that it renders properly.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Daniel M. Capella authored Sep 02, 2020 and Johannes Löthberg committed Nov 25, 2020

runcmd() taken from paccache.

Fixes FS#64328
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>
Message-Id: <20200903013655.92224-3-polyzen@archlinux.org>
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>

Daniel M. Capella authored Sep 02, 2020 and Johannes Löthberg committed Oct 23, 2020

Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>
Message-Id: <20200903013655.92224-2-polyzen@archlinux.org>
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>

Daniel M. Capella authored Sep 02, 2020 and Johannes Löthberg committed Oct 23, 2020

"Privilege escalation required" sounds more like an error.
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>
Message-Id: <20200903013655.92224-1-polyzen@archlinux.org>
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>

John A. Leuenhagen authored Oct 05, 2020 and Johannes Löthberg committed Oct 23, 2020

Signed-off-by: John A. Leuenhagen <john@zlima12.com>
Message-Id: <66d7ee9e-459b-679e-8df9-c7019b9514f2@zlima12.com>
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>

Sebastian Jakubiak authored Sep 02, 2020 and Daniel M. Capella committed Sep 02, 2020

Pactree takes care not to print both a dependency and the package to
which it resolves if they are equal. Extend (fix?) this to cover
versioned dependencies and optional dependencies containing
descriptions, so that e.g. `gnupg provides gnupg>=2` and `clang provides
clang: for qdoc` will be made more compact.

Implementation suggested by Eli Schwartz.
Signed-off-by: Sebastian Jakubiak <jakseb.dev@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Sebastian Jakubiak authored Aug 04, 2020 and Daniel M. Capella committed Sep 02, 2020

Signed-off-by: Sebastian Jakubiak <jakseb.dev@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Sebastian Jakubiak authored Aug 04, 2020 and Daniel M. Capella committed Sep 02, 2020

When pactree was run with -o/--optional turned on, limbs were sometimes
not properly cut off for the last children of packages that had no
optional dependencies. Example:

    $ pactree -a -d2 -o libluv
    libluv
    |-luajit
    | `-gcc-libs
    `-libuv
    | |-glibc
    | `-libnsl
Signed-off-by: Sebastian Jakubiak <jakseb.dev@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Sebastian Jakubiak authored Jul 30, 2020 and Daniel M. Capella committed Jul 29, 2020

Example of an incorrect behavior:

    $ pactree -a -d1 -o dia
    dia
    |-libxslt
    `-gtk2
    `-python2 (optional)

The last non-optional dependency, gtk2, has its limb drawn as if it were
the last child of a node, even though an optional dependency follows.
Signed-off-by: Sebastian Jakubiak <jakseb.dev@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Johannes Löthberg authored Jul 28, 2020 and Daniel M. Capella committed Jul 28, 2020

This makes log lines in the journal a bit more obvious.
Reported-by: Stephen Day <sd@unixtastic.com>
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Jonas Witschel authored Jul 28, 2020 and Daniel M. Capella committed Jul 28, 2020

Replace the custom "pacman_contrib_date" attribute by the built-in "localtime"
since both have the same format, but the latter respects the SOURCE_DATE_EPOCH
specification for reproducible builds.
Signed-off-by: Jonas Witschel <diabonas@archlinux.org>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Will Song authored Jun 05, 2020 and Daniel M. Capella committed Jul 27, 2020

--optional[=DEPTH] will control the depth at which optional dependencies
are printed. Its behavior is fairly simple. If the maximum depth is not
yet exceeded, and it encounters an optional dependency, it will print it
like a normal dependency except with an optional tag. A negative number
means infinite depth.
Signed-off-by: Will Song <incertia@incertia.net>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Leonid Bloch authored Jun 02, 2020 and Daniel M. Capella committed Jul 27, 2020

In situations when there are many thousands of candidates for deletion,
paccache returns an "Argument list too long" error at the freed space
calculation stage, because the expansion of the ${candidates[@]} array
becomes too long for Bash.

This commit fixes that problem, by getting the @SIZECMD@ arguments via
`printf '%s\0' "${candidates[@]}" | xargs -0`, similarly to what is done
for the (re)moving commands below.
Signed-off-by: Leonid Bloch <lb.workbox@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Daniel M. Capella authored May 09, 2020 and Johannes Löthberg committed May 26, 2020

Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>
Message-Id: <20200510015910.15077-2-polyzen@archlinux.org>
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>

Daniel M. Capella authored May 09, 2020 and Johannes Löthberg committed May 26, 2020

Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>
Message-Id: <20200510015910.15077-1-polyzen@archlinux.org>
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>

Sebastian Jakubiak authored Mar 09, 2020 and Daniel M. Capella committed Mar 15, 2020

Fix an issue where a dependency and a package providing it were
connected more than once in --graph output. The code supposed to
prevent that did not always work due to using dangling pointers.
Signed-off-by: Sebastian Jakubiak <jakseb.dev@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Sebastian Jakubiak authored Mar 06, 2020 and Daniel M. Capella committed Mar 06, 2020

Exit with non-zero status when the command line specifies more
than one package or an unknown option.

Fixes FS#64589.
Signed-off-by: Sebastian Jakubiak <jakseb.dev@gmail.com>
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>

Edward E authored Jan 06, 2020 and Johannes Löthberg committed Feb 02, 2020

Addresses https://github.com/msys2/MSYS2-packages/issues/1720

Signed-off-by: Edward E <develinthedetail@gmail.com>
Message-Id: <20200107011643.19462-2-develinthedetail@gmail.com>
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>