• Eli Schwartz's avatar
    makepkg: optimize and fix BUILDINFO generation's use of awk · 1a5f308d
    Eli Schwartz authored and Allan McRae's avatar Allan McRae committed
    
    
    The biggest issue is directly supplying the data within the format
    string which can result in misinterpreting formatter sequences if a
    printed variable contains an "%" in it. This character is currently
    permitted in the pkgver field, though not in the pkgname. Also
    pacman/libalpm itself has much looser limitations and this can appear
    anywhere at all if a package was created by some other program.
    
    For the package "iambroke-1%s-1-any.pkg.tar.xz", installed in the build
    environment, the result is:
    
      -> Generating .BUILDINFO file...
    awk: cmd. line:3: (FILENAME=- FNR=1085) fatal: not enough arguments to satisfy format string
    	`-1%s-1'
    	   ^ ran out for this one
    
    Followed by a .BUILDINFO which contains an LC_ALL=C sorted list of
    $pkgname-${epoch:+$epoch:}$pkgver-$pkgrel-$arch ending in:
    
    installed = iambroke
    
    Which is cut short, then fails to list the succeeding packages. The
    package itself successfully builds.
    
    It's also unnecessary to save the output of pacman -Qq in order to get the
    information for pacman -Qi, since the latter will, just like the former,
    return information for all installed packages if not given a package
    name(s).
    
    While I am at it, pipe this directly to awk rather than keeping a copy
    in an unnecessary local variable. This is slightly more efficient in
    addition to preventing the <<< herestring from re-interpreting the
    content of "$pkginfos" in ways that don't really matter for our usage.
    Signed-off-by: Eli Schwartz's avatarEli Schwartz <eschwartz@archlinux.org>
    Signed-off-by: Allan McRae's avatarAllan McRae <allan@archlinux.org>
    1a5f308d