• Eli Schwartz's avatar
    makepkg: reduce strictness of pkgver in depends linting · 316b031b
    Eli Schwartz authored and Allan McRae's avatar Allan McRae committed
    
    
    This change was introduced to prevent entries like depends=('foo>').
    However, it had the unintended side effect of causing a number of
    working PKGBUILDs to fail to build. This happened when a PKGBUILD
    defined one variable through calling a "complex" statement within the
    PKGBUILD's package function (e.g. a function or evaluating in a
    subshell), then used it to define the package metadata variable.
    
    extract_function_variable() cannot execute the package function in order
    to retrieve this information, so it performs a simple grep + eval instead
    and in the process misses the contextual awareness of running within the
    package function.
    
    While not catching these "issues" can result in incorrect SRCINFO, the
    resulting packages are fine. Stop aborting on the common case where the
    pkgver of a dependency is dynamically set during the package function
    until the large number of broken PKGBUILDs are fixed, and the
    restrictions of the PKGBUILD format are documented.
    
    "Fixes" FS#58776
    
    Signed-off-by: Eli Schwartz's avatarEli Schwartz <eschwartz@archlinux.org>
    Signed-off-by: Allan McRae's avatarAllan McRae <allan@archlinux.org>
    316b031b