Skip to content
  • Eli Schwartz's avatar
    makepkg: fix .PKGINFO/.BUILDINFO files swallowing status printing · 3dfec574
    Eli Schwartz authored and Allan McRae's avatar Allan McRae committed
    The respective write_* functions are low-level and shouldn't be
    outputting statuses; move these to the logic flow where they are used.
    This ensures the functions can be used in the future wherever, and also
    solves an issue where, as fallout from the message.sh retrofitting in
    commit 882e707e
    
    , the statuses got
    redirected to the actual files.
    
    The resulting package was technically correct, except that it contained
    useless lines which pacman ignored, and repo-add also ignored but at the
    same time generated an error message:
    
    /usr/bin/repo-add: line 335: declare: `=-> Generating .PKGINFO file...': not a valid identifier
    
    Thirdparty package tools with stricter parsers may abort with errors,
    and "repose" is known to do so.
    
    Signed-off-by: default avatarEli Schwartz <eschwartz@archlinux.org>
    Signed-off-by: default avatarAllan McRae <allan@archlinux.org>
    3dfec574