Skip to content
  • Eli Schwartz's avatar
    Log invalid conf settings as an error · 8e769ddb
    Eli Schwartz authored and Allan McRae's avatar Allan McRae committed
    
    
    This is not a warning, _parse_options() returns failure without even
    parsing further lines and the attempted pacman/pacman-conf program
    execution immediately aborts. Warnings are for when e.g. later on if we
    don't recognize a setting at all, we skip over it and have enough
    confidence in this to continue executing the program.
    
    The current implementation results in pacman-conf aborting with:
    
    warning: config file /etc/pacman.conf, line 60: invalid value for 'ParallelDownloads' : '2.5'
    error parsing '/etc/pacman.conf'
    
    or pacman -Syu aborting with the entirely more cryptic:
    
    warning: config file /etc/pacman.conf, line 59: invalid value for 'ParallelDownloads' : '2.5'
    
    and this isn't just a problem for the newly added ParallelDownloads
    setting, either, you could get the same problem if you specified a
    broken XferCommand, but that's harder as it's more accepting of input
    and you probably don't hit this except with unbalanced quotes.
    
    Signed-off-by: default avatarEli Schwartz <eschwartz@archlinux.org>
    Signed-off-by: default avatarAllan McRae <allan@archlinux.org>
    8e769ddb