- 18 Jun, 2018 4 commits
-
-
pacman accepts these, and there is no good reason to be more restrictive ourselves; we should follow the example of "depends" here. Update the documentation to actually state that this is supported. Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Allan McRae <allan@archlinux.org>
-
Simplifies the function a bit, but mostly, mkdir -p will never fail if the directory exists, and therefore makepkg never checks to see if it is actually writable. On the other hand, it's unnecessary to check if the directory exists once we know mkdir -p succeeded... Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
Reported-by:
Rafael Ascensão <rafa.almas@gmail.com> Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
In commit d8591dd3 when teaching --packagelist to print the full filepath for built arches only, I forgot to update the helptext at the same time as I updated the manpage. Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by:
-
- 04 Jun, 2018 1 commit
-
-
Allan McRae authored
pacman-conf returned All for any repo Usage query because it was checking if any repo options were enabled rather than if all options were enabled. Signed-off-by:
-
- 28 May, 2018 1 commit
-
-
Allan McRae authored
Signed-off-by:
-
- 27 May, 2018 6 commits
-
-
Allan McRae authored
Signed-off-by: -
Allan McRae authored
Also remove any translations that are less than 75% complete. These will be readded once translation completion passes our minimum threshold. Signed-off-by: -
Allan McRae authored
Signed-off-by: -
Allan McRae authored
Signed-off-by: -
Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by:
-
- 16 May, 2018 1 commit
-
-
In commit 5698d7b6 a new non-root use of pacman was added -- previously we used -T or -Qq, and run_pacman did not know how to special-case -Qi to skip being prepended with sudo. The result is: -> Generating .BUILDINFO file... ERROR: ld.so: object 'libfakeroot.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored. [sudo] password for eschwartz: -> Adding changelog file... Fix this by using a more generic glob since neither -Q nor -T will ever need sudo or PACMAN_OPTS Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by:
-
- 15 May, 2018 1 commit
-
-
Allan McRae authored
Signed-off-by:
-
- 13 May, 2018 4 commits
-
-
http://EditorConfig.org
Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
Since we no longer use vim-specific modelines, use the .asciidoc file extension which is, well, reserved for asciidoc formatted files. This should presumably work everywhere without needing editor-specific workarounds and configuration. Also add a shebang to makepkg.conf to indicate it contains bash content. Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
Many of these are pointless (e.g. there is no need to explicitly turn on spellchecking and language dictionaries for the manpages by default). The only useful modelines are the ones enforcing the project coding standards for indentation style (and "maybe" filetype/syntax, but everything except the asciidoc manpages and makepkg.conf is already autodetected), and indent style can be applied more easily with .editorconfig Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
This is a common URI scheme (in general if not in makepg) and we should provide a handler for it. We already allow its use for locally sourced git repositories, so it makes sense to not leave files out. Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by:
-
- 12 May, 2018 12 commits
-
-
file 5.33 introduces a new MIME type "application/x-pie-executable", which is used for relocatable binaries. makepkg ignored these binaries and did not attempt to strip them. Handle the new MIME type like the old "application/x-sharedlib". Stripping the binaries with --strip-unneeded to keep relocation information should be the correct thing to do. file 5.33 also misidentifies actual libraries as PIE executables, so we didn't strip any shared libraries, either. We now work around this bug. Signed-off-by:
Jan Alexander Steffens (heftig) <jan.steffens@gmail.com> Signed-off-by:
-
Signed-off-by: -
Attempting to compile pacman with gcc8 results in several warnings like: remove.c: In function ‘unlink_file.isra.4’: remove.c:407:34: warning: ‘.pacsave.’ directive output may be truncated writing 9 bytes into a region of size between 1 and 4096 [-Wformat-truncation=] Fix by adding checks to error out if snprintf tries to reserve a truncated filename. Because the return values are checked, gcc delegates the truncation response to our code instead of throwing warnings. Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
In commit cb0f2bd0 the changes from commit 81d233b7 seem to have been inadvertently backed out. Right now the current check doesn't do anything, since "fail" is always nothing and therefore successful. Fixes FS#58505 Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
Checking the file extension to determine if something is a signature is currently done in three places: - verify_file_signature: uses $file to print status, reuses it for comparison - source_has_signatures: uses $netfile, but removes url component if filename component exists - generate_one_checksum: uses $netfile and fails to detect renamed files This leads to inconsistent behavior when trying to use a signature of the form "foo-1.0.tar.gz.asc::https://example.com/foo-1.0.tar.gz.pgp " Fix this by treating the third case like the second case. Reported-by:
Giancarlo Razzolini <grazzolini@archlinux.org>
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
Signed-off-by:
Simon Linden <xhi2018@gmail.com> Signed-off-by:
-
Adding the architecture to the 'installed' elements of the .BUILDINFO file makes it easier to retrieve the packages needed to reconstruct the build environment. Signed-off-by:
Robin Broda <robin@broda.me> Signed-off-by:
-
Architecture information is required for repro tooling This is a revised version of https://patchwork.archlinux.org/patch/475/ Signed-off-by:
-
Since bash 4.1 extglobs can be used within [[ ... ]] regardless of whether the shopt is set. Our configure.ac requires bash 4.1.0 at a minimum for pacman scripts. Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
micro-optimization: We only care about temporarily enforcing extglob, so that is the only one we need to explicitly restore. Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
In commit 91b72cc3 support was added for linting depends/etc. to ensure they contain only valid dependency specifiers. However it did not properly take into account the possibility of dependencies linked to a specific pkgrel or epoch, which promptly failed to build because "-" and ":" is not allowed in a pkgver. pkgrel is something supported by pacman and useful for e.g. split packages which cannot be mismatched even if the pkgver is the same. Fix by removing an optional suffixed "-$decimal" when checking for a valid pkgver. epoch is kind of difficult to do without :D so likewise fix by removing an optional prefixed "$integer:" Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
Some scripts are using `break 2` to break out of the option parsing loop. Since a single `break` is sufficient in these cases, remove the extra argument. Signed-off-by:
-
- 29 Apr, 2018 8 commits
-
-
Allan McRae authored
Signed-off-by: -
Allan McRae authored
Signed-off-by: -
Allan McRae authored
Signed-off-by: -
Allan McRae authored
Signed-off-by: -
Allan McRae authored
Add all files to the relevant POTFILES.in. This avoids missing translations added to old files. Signed-off-by: -
pkg-config has built-in dependency handling, but we currently insert the raw $LIBS into libalpm's own linker flags and fail to handle Cflags at all. For dependencies which support pkg-config, simply use that instead. Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
depends, provides, conflicts, replaces, and other variables that are meant to contain package names, are now checked to ensure 1) the name component contains only characters that would equate to a valid pkgname. 2) the version component contains only characters that would equate to a valid pkgver. 3) comparison operator is a valid comparison operator (e.g. provides only allows exact = while optdepends doesn't allow anything) This also refactors pkgname into a shared utility function, wires up pkgbase optdepends and provides to use it, and gives pkgver a touchup to allow referencing where it was called from. Fixes FS#57833 and a bit of extra. Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: -
We use an extended glob here, but were relying on having it globally set in makepkg. This causes it to fail when used in scripts. Since scripts using libmakepkg may not want extglob to be set, save and restore the environment while explicitly setting extglob only where we need it. Signed-off-by:
Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by:
-
- 18 Mar, 2018 2 commits
-
-
Signed-off-by:
Christian Hesse <mail@eworm.de> Signed-off-by:
-
print_all_package_names used in_opt_array to check whether or not the PKGBUILD itself has options=('debug' 'split') -- while checking to see if it was enabled per split package which doesn't make sense as these options apply globally. This prevented debug packages from being listed if enabled via makepkg.conf rather than per PKGBUILD. Instead, use check_option to determine whether makepkg actually thinks it is meant to try creating a split debug package. Signed-off-by:Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by:
-
