Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • A arch-boxes
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 8
    • Issues 8
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Arch Linux
  • arch-boxes
  • Merge requests
  • !169

Fix shellcheck complains due to new version

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kristian Klausen requested to merge klausenbusk/arch-boxes:fix-shellcheck into master Apr 27, 2021
  • Overview 1
  • Commits 1
  • Pipelines 14
  • Changes 2
Shellcheck v0.7.2[1] added more checks resulting in the following
complains in our case:
In build-host.sh line 12:
  readonly TMPDIR="$(mktemp --dry-run --directory --tmpdir="${PWD}/tmp")"
           ^----^ SC2155: Declare and assign separately to avoid masking return values.
In build-inside-vm.sh line 16:
  readonly TMPDIR="$(mktemp --dry-run --directory --tmpdir="${PWD}/tmp")"
           ^----^ SC2155: Declare and assign separately to avoid masking return values.
In build-inside-vm.sh line 19:
    chown "${SUDO_UID}:${SUDO_GID}" "${OUTPUT}" "${TMPDIR}"
                       ^---------^ SC2153: Possible misspelling: SUDO_GID may not be assigned, but SUDO_UID is.

[1] https://github.com/koalaman/shellcheck/blob/331e89be990547b6e21ad1b6e56065bcda1ba053/CHANGELOG.md#v072---2021-04-19
Edited May 05, 2021 by Kristian Klausen
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-shellcheck