Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • A archiso
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 42
    • Issues 42
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Arch Linux
  • archiso
  • Merge requests
  • !68

archiso/mkarchiso: various fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged nl6720 requested to merge nl6720/archiso:post-!59-fixes into master Aug 20, 2020
  • Overview 1
  • Commits 1
  • Pipelines 6
  • Changes 1

Fixes to issues introduced in !59 (merged) :

  • _make_boot_on_fat(): copy initramfs from "${airootfs_dir}/boot/" not "${isofs_dir}/". Otherwise UEFI-only ISOs cannot be built.

Some general fixes:

  • Replace mkdir with install. Unlike mkdir, install does not complain when the target exists.
  • Reduce excess newlines produced by messages.
  • Ensure FAT image gets unmounted in case the script is interrupted.
  • Create the ext4 image with mkfs.ext4 instead of truncate.
  • Do not rely on user and group names for chown commands. Use numeric UID and GID instead.
  • Minimize the times stderr is redirected to /dev/null.
  • Add missing "?" to getopts.
  • Standardize function definitions by removing spaces between the function name and ().
Edited Aug 21, 2020 by nl6720
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: post-!59-fixes