Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • A archiso
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
    • Locked Files
  • Issues 42
    • Issues 42
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Arch LinuxArch Linux
  • archiso
  • Merge requests
  • !69

Pass profile directory as parameter to mkarchiso

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Runge requested to merge issues/52 into master Aug 24, 2020
  • Overview 11
  • Commits 1
  • Pipelines 4
  • Changes 4

archiso/mkarchiso:

Change all override option parameters (i.e. -A, -C, -D, -L, -P and -g) to not directly override the global variable they are tied to, but instead using an override_ prefixed variable.

Add _set_overrides() to use override_ prefixed variables (if set) to override those without a prefix.

Remove -B (a profile directory) from the list of parameters. The profile directory is now provided as separate non-option parameter.

Add a call to _read_profile(), _set_overrides() and command_build_profile() to the fallthrough option of the switch-case checking command_name - a non-option parameter to mkarchiso. This effectively provides the possibility to set the profile directory using a non-option parameter, while still maintaining compatibility to legacy named arguments used in the configs' build.sh scripts.

Extend the warning in regards to legacy build.sh based commands to mkarchiso by providing an EOL with archiso v49.

Change the help output to reflect the changes and further elaborate on the legacy commands used by build.sh scripts.

Change help output to be ordered alphabetically.

Add help output for -r and -g options.

Call _set_overrides() for legacy commands that accept one or more of the overriden options (i.e. command_init, command_install, command_prepare and command_iso).

configs/{baseline,releng}/build.sh:

Change call to mkarchiso to use the profile's directory as a named argument instead of an option-argument.

README.rst:

Fix documentation on how to call mkarchiso with a profile directory.

Fix wording and ordering of option arguments for run_archiso documentation.

Fixes #52 (closed)

Edited Aug 25, 2020 by David Runge
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issues/52