Skip to content
Snippets Groups Projects

feature(keyringctl): support query expressions for packet field selection

Merged Levente Polyak requested to merge fix/packet-query-expr into master
All threads resolved!

Instead of simply string matching a line, we now traverse the packet as a tree and match the path based on a depth first search.

While traversing, we support logical OR and current depth * wildcard processed as a component based query expression.

Callee's are adjusted to specifically select the appropriate Issuer at the correct depth.

Fixes #185 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I like this approach! :tada: I found one bug in the tree traversal, see inline comment, that would stop arojas's key from getting validated correctly, see the inline comment, otherwise this looks good to me :)

  • Levente Polyak added 1 commit

    added 1 commit

    • 099df52a - feature(keyringctl): support query expressions for packet field selection

    Compare with previous version

  • Levente Polyak resolved all threads

    resolved all threads

  • Jonas Witschel approved this merge request

    approved this merge request

  • David Runge approved this merge request

    approved this merge request

  • The change looks alright. Happy to see you also extended the tests to check for return values :cat:

  • Please register or sign in to reply
    Loading