Skip to content
GitLab

check if the autodetected architectures are valid.

Open Christian Heusel requested to merge gromit/devtools:build-arch-autodetection into master

Currently when building a package from the AUR using pkgctl the following error can arise:

$ pkgctl build --repo extra teleport-bin
==> Building teleport-bin
  ->   repo: extra
  ->   arch: armv7h aarch64 x86_64
  -> worker: chris-2
==> Building teleport-bin for [extra] (armv7h)
/usr/local/share/devtools/lib/build/build.sh: line 401: extra-armv7h-build: command not found

This is only a problem when using the autodetection, as the --arch option will reject wrong args:

$ pkgctl build --arch armv7h --repo extra teleport-bin
==> ERROR: invalid architecture: armv7h

This MR just also applies this logic to the autodetected arches and skips anything that is not a valid arch array with a warning:

$ pkgctl build --repo extra teleport-bin
==> Building teleport-bin
==> WARNING: invalid architecture, not building for: armv7h
==> WARNING: invalid architecture, not building for: aarch64
  ->   repo: extra
  ->   arch: x86_64
  -> worker: chris-2
==> Building teleport-bin for [extra] (x86_64)

Maybe this can also be part of the next bugfix release (Version %v1.0.3) as its just a small change.